Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 9 #455

Closed
niyid opened this issue Jan 4, 2020 · 10 comments
Closed

For Cycle 9 #455

niyid opened this issue Jan 4, 2020 · 10 comments

Comments

@niyid
Copy link

niyid commented Jan 4, 2020

Summary

Specify the total amount of BSQ you are requesting:

  • BSQ requested:
    2,500 BSQ

Contributions delivered

bisq-network/bisq#3352 - 1,000 BSQ (issue was resolved over an extended period of reviewing variant and sometimes conflicting points of view to arrive at a consensus - widely accepted resolution).

bisq-network/bisq#3510 - 1,500 BSQ (1,000 BSQ for discovery of critical "showstopper" bug and 500 BSQ for resolution)

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional, and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

Monero Integration Incubator Project - Milestones 4b, 4c, 4d, 4e and 5

bisq-network/bisq#3292
bisq-network/bisq#3328
bisq-network/bisq#3338
bisq-network/bisq#3401
bisq-network/bisq#3408

Roles performed

Provide links to your monthly report on any roles you are responsible for.

@chimp1984
Copy link

I think both tasks have been rather trivial and the requested amount is too high IMO.

@niyid
Copy link
Author

niyid commented Jan 8, 2020 via email

@niyid
Copy link
Author

niyid commented Jan 9, 2020

OK. What is Bisq policy of bounty payment for discovering a severe bug(showstopper)? And what in your opinion is a good value for each?

@chimp1984

I am still awaiting you response to the above.

@chimp1984
Copy link

chimp1984 commented Jan 9, 2020

OK. What is Bisq policy of bounty payment for discovering a severe
bug(showstopper)?

For severe bug please use practice of responsible reporting. We will compensate fair.

@chimp1984
Copy link

what in your opinion is a good value for each?

For bisq-network/bisq#3513 I would request 50-100 USD (not a critical bug, only added catch and navigation call).

For bisq-network/bisq#3366 I would charge 100-150 USD. (adding a textfield using existing domain method, lots of back and forth in PR discussion)

Feel free to see my own requests for comparable "trivial" PRs. But its your decision at the end what you request.
As we suffer from lack of management I will switch to strict mode and only upvote what I would pay if I would pay a freelancer in a company.

@niyid
Copy link
Author

niyid commented Jan 9, 2020

what in your opinion is a good value for each?

For bisq-network/bisq#3513 I would request 50-100 USD (not a critical bug, only added catch and navigation call).

What makes a bug a showstopper (critical)? I would think that is from the user's/tester's point of view and not the developer's. As I recall, if a bug cannot be circumvented (with a workaround) to allow the user to continue using the software, then it is a showstopper; and the triviality of the solution does not in anyway change the definition of a showstopper. With this bug, the Bisq instance was perpetually stuck during launch and the main screen never loads.

And I recall Bisq having a policy to pay 1000 BSQ for reporting a critical bug. Therefore I actually requested 500 BSQ for resolving it and 1000 BSQ for discovering it.

For bisq-network/bisq#3366 I would charge 100-150 USD. (adding a textfield using existing domain method, lots of back and forth in PR discussion)

Aha. The lots of "back and forth" and ensuring there is a consensus on terminologies and the delivery is all part of the effort put into the work, isn't it?

Feel free to see my own requests for comparable "trivial" PRs. But its your decision at the end what you request.
As we suffer from lack of management I will switch to strict mode and only upvote what I would pay if I would pay a freelancer in a company.

Well, good luck with your plan to treat Bisq like a gig job.

@chimp1984
Copy link

@niyid When persisted navigation view did not exist anymore it was just a blank page. I never had any further problems when this happened (mostly during dev testing) beside to click on the menu buttons to move to any other page.

Don't understand me wrong. I don't want to make your contribution smaller, just bring it to relation to others (like myself) and to ask the question how much would you pay a freelancer for such a task if you pay it from your pocket. I tried to give an estimate how much I would pay and use that for my vote decision. Others might have different views. We have been too tolerant and did not enough due dilligence in the past. In context of the low revenue (about 10-15K USD/month) we have to fix that lack of management and checks otherwise BSQ goes to zero and with it Bisq. I hope you understand and don't consider that as personal thing. You will see at other requests that I apply that to all requests now and will vote accordingly.

@niyid
Copy link
Author

niyid commented Jan 14, 2020

@niyid When persisted navigation view did not exist anymore it was just a blank page. I never had any further problems when this happened (mostly during dev testing) beside to click on the menu buttons to move to any other page.

Don't understand me wrong. I don't want to make your contribution smaller, just bring it to relation to others (like myself) and to ask the question how much would you pay a freelancer for such a task if you pay it from your pocket. I tried to give an estimate how much I would pay and use that for my vote decision. Others might have different views. We have been too tolerant and did not enough due dilligence in the past. In context of the low revenue (about 10-15K USD/month) we have to fix that lack of management and checks otherwise BSQ goes to zero and with it Bisq. I hope you understand and don't consider that as personal thing. You will see at other requests that I apply that to all requests now and will vote accordingly.

@chimp1984
Thanks for your response; but I am not taking anything personal. I have simply pointed out to you that the issue was a critical bug (showstopper). With this issue, Bisq would NEVER even load and the user/tester would be none wiser because he never gets any feedback - it just appears to hang.

This was different from the "blank page" you described. You have clearly stated that there was a work-around for the "blank page" which was to click on another menu button; meaning that was not a critical bug (or showstopper).

Of course we are all different individuals with our peculiar opinions therefore differing opinions are expected and welcome.

Regards.

@chimp1984
Copy link

Ah ok, then I mis-interpreted the bug and the fix.

@MwithM
Copy link
Contributor

MwithM commented Jan 21, 2020

Rejected through DAO vote. Left open for discussion.

@MwithM MwithM closed this as completed Jan 28, 2020
@ripcurlx ripcurlx mentioned this issue Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants