Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 20 #741

Closed
ghubstan opened this issue Dec 26, 2020 · 6 comments
Closed

For Cycle 20 #741

ghubstan opened this issue Dec 26, 2020 · 6 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:failed Indicates that DAO vote failed to complete.
Milestone

Comments

@ghubstan
Copy link

ghubstan commented Dec 26, 2020

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 12857.14
  • USD requested: 9000
  • BSQ rate: 0.7 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 19 #716

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Define new grpc bsq/btc balances protos dev 25 bisq-network/bisq#4793 merged
Add proto wrappers for sending bsq, btc or all balances dev 100 bisq-network/bisq#4794 merged
Define proto for api method 'getunusedbsqaddress' dev 25 bisq-network/bisq#4795 merged
Define proto for api method 'sendbsq' dev 25 bisq-network/bisq#4796 merged
Add proto fields to support trade fee currency choice dev 15 bisq-network/bisq#4797 merged
Implement and test api method 'getunusedbsqaddress' dev 500 bisq-network/bisq#4798 merged
Implement and test new getbalance(s) api methods dev 800 bisq-network/bisq#4799 merged
Stub out api method 'sendbsq' in core dev 350 bisq-network/bisq#4800 merged
Refactor desktop's BsqSendView 'sendbsq', share with api dev 150 bisq-network/bisq#4801 merged
Support paying trade fees in bsq or btc in api dev 650 bisq-network/bisq#4802 merged
Delete deprecated api wallet test, adjust api build/run doc dev 0 bisq-network/bisq#4803 merged
Refactor getbalance (bsq and/or btc) api dev 300 bisq-network/bisq#4808 merged
Add api method 'getpaymentmethods' dev 300 bisq-network/bisq#4818 merged
Add api method 'getpaymentacctform' dev 300 bisq-network/bisq#4819 merged
Replace existing api method 'createpaymentacct' impl dev 900 bisq-network/bisq#4821 merged
Fix api's createpaymentacct validation problems dev 0 bisq-network/bisq#4824 merged
Add more 'createpaymentacct' api tests dev 300 bisq-network/bisq#4828 merged
Set country on MoneyGram acct in gson type adapter dev 0 bisq-network/bisq#4834 merged
Update bats api test dev 0 bisq-network/bisq#4836 merged
Add tx fee rate api methods, requested changes in prior PRs dev 800 bisq-network/bisq#4858 merged
Refactor: move getDust(Transaction transaction) dev 25 bisq-network/bisq#4884 merged
Refactor BtcWalletService to let api override fee rates dev 200 bisq-network/bisq#4896 merged
Add optional txFeeRate parameter to api sendbsq dev 350 bisq-network/bisq#4900 merged
Add new api method 'sendbtc' and test dev 850 bisq-network/bisq#4922 merged
Support tx memo field for btc withdrawals from api dev 150 bisq-network/bisq#4925 merged
Use Bisq's UserThread.executor in gRPC server dev 0 bisq-network/bisq#4936 merged
Add new api method gettransaction dev 735 bisq-network/bisq#4948 merged
Refactor (improve) gRPC service error handling dev 50 bisq-network/bisq#4960 merged
Prevent excessive api calls dev 1100 bisq-network/bisq#4966 merged

Also participated in some PR reviews.

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

Participating in some currently open PR reviews.

@ghubstan ghubstan changed the title [WIP] For Cycle 20 For Cycle 20 Dec 27, 2020
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Dec 27, 2020
@MwithM MwithM added this to the Cycle 20 milestone Dec 27, 2020
@ripcurlx
Copy link
Contributor

@sqrrm @chimp1984 Could you please review this request as it is hard to review this CR if you haven't followed all mentioned PRs above already. Thanks!

@ghubstan
Copy link
Author

ghubstan commented Dec 28, 2020

@sqrrm @chimp1984 Could you please review this request as it is hard to review this CR if you haven't followed all mentioned PRs above already. Thanks!

One of the reasons this is a difficult CR to review is because two long PR chains contain some PRs that were reviewed and approved, but were skipped over during the merge phase. The final or last few of the PRs in the chain were explicitly merged, and all prior approved PRs in a chain were implicitly merged.

For example, PR 4818 was the 13th PR (denoted by the branch name prefix 13-) in a chain of 21, ending with PR 4858. Though PR 4818 is Closed, the comment explains the PR was merged when the final PR in the chain was merged.

I think @sqrrm will confirm this for you, but I need to explain it.

@sqrrm
Copy link
Member

sqrrm commented Dec 28, 2020

I approve of this compensation request. It has been mostly straight forward to review, just looks a bit messy when comment fixes come on top of a much later PR.

@ripcurlx
Copy link
Contributor

Based on #741 (comment) as team lead I approve this request. Please submit your DAO proposal and paste the transaction ID here as a comment when complete, thanks.

@ghubstan
Copy link
Author

f8deecd9a02d028d6f63982f12fd37896f585b40b162a35ba9697d3a662882d1

@MwithM MwithM added the was:failed Indicates that DAO vote failed to complete. label Jan 10, 2021
@MwithM
Copy link
Contributor

MwithM commented Jan 10, 2021

Cycle 20 DAO vote failed. Submit a new DAO request for next cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:failed Indicates that DAO vote failed to complete.
Projects
Archived in project
Development

No branches or pull requests

4 participants