Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place Bisq AGPL license header at top of all Java sources #8

Open
cbeams opened this issue Mar 20, 2018 · 3 comments
Open

Place Bisq AGPL license header at top of all Java sources #8

cbeams opened this issue Mar 20, 2018 · 3 comments

Comments

@cbeams
Copy link
Contributor

cbeams commented Mar 20, 2018

All .java files should adhere to the following template:

/*
 * This file is part of Bisq.
 *
 * Bisq is free software: you can redistribute it and/or modify it
 * under the terms of the GNU Affero General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or (at
 * your option) any later version.
 *
 * Bisq is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
 * License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
 */

package bisq.example;

public class Example {
}

Note the single blank line between license header and package statement and between package and class declaration.

cbeams added a commit to bisq-network/bisq-statsnode that referenced this issue Mar 20, 2018
cbeams added a commit to bisq-network/bisq-p2p that referenced this issue Mar 20, 2018
cbeams added a commit to bisq-network/bisq-seednode that referenced this issue Mar 20, 2018
cbeams added a commit to bisq-network/dao that referenced this issue Mar 20, 2018
cbeams added a commit to bisq-network/bisq-monitor-deprecated that referenced this issue Mar 20, 2018
cbeams added a commit to bisq-network/bisq-core that referenced this issue Mar 20, 2018
cbeams added a commit to bisq-network/bisq that referenced this issue Mar 20, 2018
@cbeams
Copy link
Contributor Author

cbeams commented Mar 20, 2018

I've added common IDEA file templates in the commits above, but there appears to be a bug in IDEA that may cause them to be ignored. As such, you may still need to set them up manually in Preferences->Editor->File and Code Templates (see the Files->[Class,Interface,Enum,AnnotationType] and Includes->File Header sections). Others' experience reports would be appreciated.

@sqrrm
Copy link
Member

sqrrm commented Mar 20, 2018

Indeed, I couldn't get IDEA to read the files, had to edit them through the settings editor for it to take effect.

@cbeams
Copy link
Contributor Author

cbeams commented Mar 20, 2018

The bug seems to be that IDEA doesn't respect toggling from Default to Project in that settings panel. I found at least some of the time, though, that attempting to toggle would cause the settings to get picked up, even though the setting didn't ultimately persist. 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants