Correct the name of the process_record handler in hyper7 default keymap #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original hyper7 layout is defined with 183 keys. The PCB caters for a full 1u daughterboard layout if preferred. Updates info.json to allow creation of 183 (hyper7) and 213 (1u) key layout. Updates current keymaps to use the 183 key layout. Moves unicode configuration to keymap level (configurator doesn't currently work with unicode config).
Previously (and incorrectly) mapped to SUBSET_OF
END_OF_PROOF (0x220E) -> THERE EXISTS (0x2203)
It's process_record_kb, not process_record_keymap.
bit-shifter
reviewed
Jan 18, 2023
There was a problem hiding this comment.
Thanks @spenczar - apologies for this taking so long.
I'll add this to other layout too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's process_record_kb, not process_record_keymap.
In addition, users should be able to define their own behavior through
process_record_user(see discussion in qmk#8246).