New Release v1.4.0 (#1533)

* New release v1.4.0
* Fixes #1532: AttributeError: can't set attribute 'showHiddenFiles' in app.py#1276
* Add real author names of the new developer team

AUTHORS

@@ -2,4 +2,7 @@ Oprea Dan (<dan@le-web.org>)
 Bart de Koning (<bratdaking@gmail.com>)
 Richard Bailey (<rmjb@mail.com>)
 Germar Reitze (<germar.reitze@gmail.com>)
-Taylor Raack (taylor@raack.info)
+Taylor Raack (<taylor@raack.info>)
+Christian Buhtz
+Michael Büker
+Jürgen Altfeld

CHANGES

@@ -1,9 +1,10 @@
 Back In Time
 
-Version 1.3.4-dev (development of upcoming release)
+Version 1.4.0 (2023-09-14)
 * Project: Renamed branch "master" to "main" and started "gitflow" branching model.
 * Refactor: Renamed qt4plugin.py to systrayiconplugin.py (we are using Qt5 for years now ;-)
 * Refactor: Removed unfinished feature "Full system backup" (#1526)
+* Fix bug: AttributeError: can't set attribute 'showHiddenFiles' in app.py (#1532)
 * Fix bug: Check SSH login works on machines with limited commands (#1442)
 * Fix bug: Missing icon in SSH private key button (#1364)
 * Fix bug: Master issue for missing or empty system-tray icon (#1306)

README.md

@@ -4,8 +4,8 @@
 [![Translation status](https://translate.codeberg.org/widgets/backintime/-/svg-badge.svg)](https://translate.codeberg.org/engage/backintime)
 
 # Back In Time
-<sub>Copyright (C) 2008-2022 Oprea Dan, Bart de Koning, Richard Bailey,
-Germar Reitze, Taylor Raack<sub>
+<sub>Copyright (C) 2008-2023 Oprea Dan, Bart de Koning, Richard Bailey,
+Germar Reitze, Taylor Raack, Christian Buhtz, Michael Büker, Jürgen Altfeld<sub>
 
 It is an easy-to-use backup tool for files and folders.
 It runs on GNU Linux and provides a command line tool `backintime` and a
@@ -24,7 +24,8 @@ You only need to specify 3 things:
 
 ## Maintenance status
 
-A small team has started in summer 2022 to get things moving again after the
+A small team (Christian Buhtz, Michael Büker and Jürgen Altfeld)
+has started in summer 2022 to get things moving again after the
 development of this project has been dormant for a while.
 Stick with us, we all ♥️ _Back In Time_. 😁
 
@@ -35,7 +36,7 @@ instead of implementing new
 If you are interested in the development, please
 see [CONTRIBUTING](CONTRIBUTING.md) and have a look on
 [open issues](https://github.com/bit-team/backintime/issues) especially
-those labeld as [good first](https://github.com/bit-team/backintime/labels/GOOD%20FIRST%20ISSUE)
+those labeled as [good first](https://github.com/bit-team/backintime/labels/GOOD%20FIRST%20ISSUE)
 and [help wanted](https://github.com/bit-team/backintime/issues?q=is%3Aissue+is%3Aopen+label%3AHELP-WANTED).
 
 ## Index
@@ -112,15 +113,22 @@ to be prepared to build an updated version of the package:
  makepkg -si
 
 ## Known Problems and Workarounds
- - [File permissions handling and therefore possible non-differential backups](#file-permissions-handling-and-therefore-possible-non-differential-backups)
- - [Non-working password safe and BiT forgets passwords (keyring backend issues)](#non-working-password-safe-and-bit-forgets-passwords-keyring-backend-issues)
- - [Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).](#warning-apt-key-is-deprecated-manage-keyring-files-in-trustedgpgd-instead-see-apt-key8)
- - [Tray icon or other icons not shown correctly](#tray-icon-or-other-icons-not-shown-correctly)
- - [Problems in versions older then the last stable release](#problems-in-versions-older-then-the-last-stable-release)
- - [Incompatibility with rsync >= 3.2.4](#incompatibility-with-rsync-324-or-newer)
- - [Python 3.10 compatibility and Ubuntu version](#python-310-compatibility-and-ubuntu-version)
 
-### File permissions handling and therefore possible non-differential backups
+In the latest stable release:
+- [File permissions handling and therefore possible non-differential backups](#file-permissions-handling-and-therefore-possible-non-differential-backups)
+- [Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).](#warning-apt-key-is-deprecated-manage-keyring-files-in-trustedgpgd-instead-see-apt-key8)
+
+In older releases:
+- [Tray icon or other icons not shown correctly](#tray-icon-or-other-icons-not-shown-correctly)
+- [Non-working password safe and BiT forgets passwords (keyring backend issues)](#non-working-password-safe-and-bit-forgets-passwords-keyring-backend-issues)
+- [Incompatibility with rsync >= 3.2.4](#incompatibility-with-rsync-324-or-newer)
+- [Python 3.10 compatibility and Ubuntu version](#python-310-compatibility-and-ubuntu-version)
+
+### Problems in the latest stable release
+
+All releases can be found in the [list of releases](https://github.com/bit-team/backintime/releases).
+
+#### File permissions handling and therefore possible non-differential backups
 
 In version 1.2.0, the handling of file permissions changed.
 In versions <= 1.1.24 (until 2017) all file permissions were set to `-rw-r--r--` in the backup target.
@@ -134,7 +142,39 @@ to add `--no-perms --no-group --no-owner` to it.
 Note that the exact file permissions can still be found in `fileinfo.bz2` and are also considered when restoring
 files.
 
-### Non-working password safe and BiT forgets passwords (keyring backend issues)
+#### Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
+
+In newer Ubuntu-based distros you may get this warning if you manually install _Back In Time_
+as described in the [Installation](#installation) section here.
+
+The reason is that public keys of signed packages shall be stored in a new folder now
+(for details see https://itsfoss.com/apt-key-deprecated/).
+
+You can currently ignore this warning until we have found a reliable way
+to support all Ubuntu distros (older and newer ones).
+
+This issue is tracked in [#1338](https://github.com/bit-team/backintime/issues/1338).
+
+### Problems in versions older than the latest stable release
+
+#### Tray icon or other icons not shown correctly
+
+**Status: Fixed in v1.4.0**
+
+Missing installations of Qt5-supported themes and icons can cause this effect.
+_Back In Time_ may activate the wrong theme in this
+case leading to some missing icons. A fix for the next release is in preparation.
+
+As clean solution, please check your Linux settings (Appearance, Styles, Icons)
+and install all themes and icons packages for your preferred style via
+your package manager.
+
+See issues [#1306](https://github.com/bit-team/backintime/issues/1306)
+and [#1364](https://github.com/bit-team/backintime/issues/1364).
+
+#### Non-working password safe and BiT forgets passwords (keyring backend issues)
+
+**Status: Fixed in v1.3.3 (mostly) and v1.4.0**
 
 _Back in Time_ does only support selected "known-good" backends
 to set and query passwords from a user-session password safe by
@@ -168,33 +208,6 @@ default-keyring=keyring.backends.kwallet.DBusKeyring
 
 See also issue [#1321](https://github.com/bit-team/backintime/issues/1321)
 
-### Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
-
-In newer Ubuntu-based distros you may get this warning if you manually install _Back In Time_
-as described in the [Installation](#installation) section here.
-
-The reason is that public keys of signed packages shall be stored in a new folder now
-(for details see https://itsfoss.com/apt-key-deprecated/).
-
-You can currently ignore this warning until we have found a reliable way
-to support all Ubuntu distros (older and newer ones).
-
-This issue is tracked in [#1338](https://github.com/bit-team/backintime/issues/1338).
-
-### Tray icon or other icons not shown correctly
-
-Missing installations of Qt5-supported themes and icons can cause this effect.
-_Back In Time_ may activate the wrong theme in this
-case leading to some missing icons. A fix for the next release is in preparation.
-
-As clean solution, please check your Linux settings (Appearance, Styles, Icons)
-and install all themes and icons packages for your preferred style via
-your package manager.
-
-See issues [#1306](https://github.com/bit-team/backintime/issues/1306)
-and [#1364](https://github.com/bit-team/backintime/issues/1364).
-
-### Problems in versions older than the latest stable release
 #### Incompatibility with rsync 3.2.4 or newer
 
 The release (`1.3.2`) and earlier versions of _Back In Time_ are incompatible with `rsync >= 3.2.4` ([#1247](https://github.com/bit-team/backintime/issues/1247)). The problem is [fixed](https://github.com/bit-team/backintime/pull/1351) in the current master branch of that repo and will be released with the next release (`1.3.3`) of _Back In Time_.

VERSION

@@ -1 +1 @@
-1.3.4-dev
+1.4.0

common/config.py

@@ -66,12 +66,12 @@
 
 class Config(configfile.ConfigFileWithProfiles):
  APP_NAME = 'Back In Time'
- VERSION = '1.3.4-dev'
+ VERSION = '1.4.0'
  COPYRIGHT = 'Copyright (C) 2008-2022 Oprea Dan, Bart de Koning, ' \
  'Richard Bailey, Germar Reitze'
 
  CONFIG_VERSION = 6
- """Latest or highest possible version of Backin Time's config file."""
+ """Latest or highest possible version of Back in Time's config file."""
 
  NONE = 0
  AT_EVERY_BOOT = 1

common/doc-dev/conf.py

@@ -65,7 +65,7 @@
 # built documents.
 #
 # The short X.Y version.
-version = '1.3.4-dev'
+version = '1.4.0'
 # The full version, including alpha/beta/rc tags.
 release = version # '1.3.3-dev'
 

common/man/C/backintime-askpass.1

@@ -1,4 +1,4 @@
-.TH backintime-askpass 1 "Jan 2023" "version 1.3.4-dev" "USER COMMANDS"
+.TH backintime-askpass 1 "Sept 2023" "version 1.4.0" "USER COMMANDS"
 .SH NAME
 backintime-askpass \- a simple backup tool for Linux.
 .PP

common/man/C/backintime-config.1

@@ -1,4 +1,4 @@
-.TH backintime-config 1 "Aug 2023" "version 1.3.4-dev" "USER COMMANDS"
+.TH backintime-config 1 "Sept 2023" "version 1.4.0" "USER COMMANDS"
 .SH NAME
 config \- BackInTime configuration files.
 .SH SYNOPSIS

common/man/C/backintime.1

@@ -1,4 +1,4 @@
-.TH backintime 1 "Jan 2023" "version 1.3.4-dev" "USER COMMANDS"
+.TH backintime 1 "Sept 2023" "version 1.4.0" "USER COMMANDS"
 .SH NAME
 backintime \- a simple backup tool for Linux.
 .PP

debian/changelog

@@ -1,4 +1,42 @@
-backintime (1.3.4-dev) unstable; urgency=low
- Nothing yet.
+backintime (1.4.0) unstable; urgency=low
+ * Project: Renamed branch "master" to "main" and started "gitflow" branching model.
+ * Refactor: Renamed qt4plugin.py to systrayiconplugin.py (we are using Qt5 for years now ;-)
+ * Refactor: Removed unfinished feature "Full system backup" (#1526)
+ * Fix bug: Check SSH login works on machines with limited commands (#1442)
+ * Fix bug: Missing icon in SSH private key button (#1364)
+ * Fix bug: Master issue for missing or empty system-tray icon (#1306)
+ * Fix bug: System-tray icon missing or empty (GUI and cron) (#1236)
+ * Fix bug: Improve KDE plasma icon compatibility (#1159)
+ * GUI Change: View last (snapshot) log button in GUI uses "document-open-recent" icon now instead of "document-new" (#1386)
+ * Fix bug: Unit test fails on some machines due to warning "Ignoring XDG_SESSION_TYPE=wayland on Gnome..." (#1429)
+ * Fix bug: Generation of config-manpage caused an error with Debian's Lintian (#1398).
+ * Fix bug: Return empty list in smartRemove (#1392, Debian Bug Report 973760)
+ * Fix bug: Taking a snapshot reports `rsync` errors now even if no snapshot was taken (#1491)
+ * Fix bug: takeSnapshot() recognizes errors now by also evaluating the rsync exit code (#489)
+ Fixes related problem: Killing `rsync` was not handled gracefully (by ignoring the rsync exit code)
+ * Fix bug: The error user-callback is now always called if an error happened while taking a snapshot (#1491)
+ * Fix bug: D-Bus serviceHelper error "LimitExceeded: Maximum length of command line reached (100)":
+ Max command length is now 120 instead of 100 (#1027)
+ * Feature: Introduce new error codes for the "error" user callback (as part of #1491):
+ 5: Error while taking a snapshot.
+ 6: New snapshot taken but with errors.
+ * Feature: The `rsync` exit code is now contained in the snapshot log (part of #489). Example:
+ [E] Error: 'rsync' ended with exit code -9 (negative values are signal numbers, see 'kill -l')
+ * Fix bug: Treat rsync exit code 24 as INFO instead of ERROR (#1506)
+ * Breaking change: Minimal Python version 3.8 required (#1358).
+ * Removed: Handling and checking of user group "fuse" (#1472).
+ * Feature: Exclude /swapfile by default (#1053)
+ * Feature: Rearranged menu bar and its entries in the main window (#1487, #1478).
+ * Feature: Configure user interface language via config file and GUI.
+ * Documentation: Removed outdated docbook (#1345).
+ * Build: Introduced .readthedocs.yaml as asked by ReadTheDocs.org (#1443).
+ * Dependency: The oxygen icons should be installed with the BiT Qt GUI since they are used as fallback in case of missing icons
+ * Fix bug: Add support for ChainerBackend class as keyring which iterates over all supported keyring backends (#1410)
+ * Translation: Strings to translate now easier to understand for translators (#1448, #1457, #1462, #1465).
+ * Translation: Improved completeness of translations and additional modifications of source strings (#1454, #1512)
+ * Translation: Plural forms support (#1488).
+ * Removed: Translation in Canadian English, British English and Javanese (#1455).
+ * Added: Translation in Persian and Vietnamese (#1460).
+ * Added: Message to users (after 10 starts of BIT Gui) to motivate them contributing translations (#1473).
 
- -- BIT Team <dan@le-web.org> Mon, 16 Jan 2023 10:13:20 +0100
+ -- Germar Reitze <germar.reitze@gmail.com> Thu, 14 Sep 2023 21:16:22 +0200

qt/app.py

@@ -412,13 +412,18 @@ def __init__(self, config, appInstance, qapp):
 
  # BIT counts down how often the GUI was started. Until the end of that
  # countdown a dialog with a text about contributing to translating
- # BIT is prestented to the users.
+ # BIT is presented to the users.
  self.config.decrement_manual_starts_countdown()
 
  @property
  def showHiddenFiles(self):
  return self.config.boolValue('qt.show_hidden_files', False)
 
+ # TODO The qt.show_hidden_files key should be a constant instead of a duplicated string
+ @showHiddenFiles.setter
+ def showHiddenFiles(self, value):
+ self.config.setBoolValue('qt.show_hidden_files', value)
+
  def _create_actions(self):
  """Create all action objects used by this main window.
 
@@ -786,8 +791,6 @@ def closeEvent(self, event):
  self.config.setIntValue('qt.main_window.files_view.size_width', self.filesView.header().sectionSize(1))
  self.config.setIntValue('qt.main_window.files_view.date_width', self.filesView.header().sectionSize(2))
 
- self.config.setBoolValue('qt.show_hidden_files', self.showHiddenFiles)
-
  self.config.setIntValue('qt.main_window.files_view.sort.column', self.filesView.header().sortIndicatorSection())
  self.config.setBoolValue('qt.main_window.files_view.sort.ascending', self.filesView.header().sortIndicatorOrder() == Qt.AscendingOrder)
 

qt/man/C/backintime-qt.1

@@ -1,4 +1,4 @@
-.TH backintime-qt 1 "Jan 2023" "version 1.3.4-dev" "USER COMMANDS"
+.TH backintime-qt 1 "Sept 2023" "version 1.4.0" "USER COMMANDS"
 .SH NAME
 backintime-qt \- a simple backup tool.
 .SH SYNOPSIS