Toolbar has no option to display items as text

[billkendrick]

Introduction

Welcome to the project, if you pick up this Issue because of the
"GOOD FIRST USE" label. You will be mentored through the process if you
want. First the Issue is explained. At the end you will find some
guidance for first contributors. Please do not hesitate to ask questions.
Your solution don't need to be perfect.

Participation or contribution is not recommended unless you are familiar with Back In Time and are an active user. This project is not intended for learning basic Python skills or enhancing your GitHub profile.

Problem

The toolbar in Back In Time shows icons only. While tooltips appear after hovering on them, there appears to be no option to display the tools with text (or as text-only).

Solution

Provide option in the toolbar (available via right-click menu) to display entries as: Icons only, Text only, Text Alongside Icons, and Text Under icons. For comparison see other applications like Kate text editor or Okular image viewer.

Your next steps

1. If this is your first contribution in this project please introduce
   your self and tell us about your skills, wishes and plans. Also let us
   know how you found the issue and the project.
2. Read the existing contributors documentation.
3. We can develop the next steps in the further discussion. Don't hesitate to ask.

Original post from Bill Kendrick (billkendrick)

The toolbar in Back In Time shows icons only. While tooltips appear after hovering on them, there appears to be no option to display the tools with text (or as text-only).

Compare to Kate text editor or Okular image viewer. Their toolbars provide options (available via right-click menu) to display entries as: Icons only, Text only, Text Alongside Icons, and Text Under icons.

Thanks for your consideration!

Version: 1.2.1
Source: Kubuntu 20.04 repositories

[buhtz]

Why do you need text there?

I would assume this FeatureRequest is out of project ressources here or you could say it is not important enough compared to other Issues and open PRs. Sorry.

Maybe you can provide a PR?

[billkendrick]

I would call this "nice-to-have," since the hover option is probably a suitable alternative. I'm used to most other Qt & KDE apps having text labels on buttons, as a configurable option, and it's helpful for new users to understand what a button does before pressing it. 😄

I assumed (sorry!) that it would be trivial, though without having any personal experience developing Qt apps myself. Feel free to close if you deem this "won't-fix". Thanks!

[emtiu]

This functionality existed in the past (verified for backintime 1.0.36 on KDE4 in an old VM), but my current best guess is that it has disappeared in migration to Qt5 with 1.2.0 (see also #167).

I also think it would be nice to have it back, if only to conform better to KDE standards.

[s4moore]

Hello, I would to work on this issue.

I have completed one small task already for BIT and found that task through a search for "Good First Issue".

I have some experience in C, Python, HTML / CSS, Javascript, and a little bit of React, and am trying to develop my skills.

Thanks,
Sam

[buhtz]

Hello Samuel,
thank you for your efforts. Let me know if I can be of assistance. Don't hesitate to ask.
Regards,
Christian

[s4moore]

Hi Christian,

Many thanks, is it best to message you here?

[buhtz]

Yes. Here or in a PR if you have opened one.

[daviewales]

I'm getting this error since commit 9f7891e:

Traceback (most recent call last):
  File "/usr/share/backintime/qt/app.py", line 2459, in <module>
    mainWindow = MainWindow(cfg, appInstance, qapp)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/backintime/qt/app.py", line 135, in __init__
    self._create_main_toolbar()
  File "/usr/share/backintime/qt/app.py", line 796, in _create_main_toolbar
    Qt.ToolButtonStyle(StateData().toolbar_button_style))
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'StateData' object has no attribute 'toolbar_button_style'

[buhtz]

Mhm... it should be there.

backintime/qt/statedata.py

Lines 361 to 372 in c89805b

	@property
	def toolbar_button_style(self) -> int:
	"""Style of icons for the main toolbar.
	Returns:
	Style value as integer (default: 0 as ``ToolButtonIconOnly``)
	"""
	try:
	return self['gui']['mainwindow']['toolbar_button_style']
	except KeyError:
	self.toolbar_button_style = 0
	return self.toolbar_button_style

Maybe you somehow mixed some versions of the code? Are you on the latest dev?

[daviewales]

Sorry, I must have mixed something up. It's working now.