feat: Extend diagnostic information's #1318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend diagnostic information's
About 1: Related to #1316 where the path to systems python interpreter was "hacked" via "pyenv". This info will catch situations like that.
About 2: Related to #1247. Rsync 3.2.4 do use a different way of argument protection. The situation is complex and the environment variables RSYNC_OLD_ARGS and RSYNC_PROTECT_ARGS to influence that.
About 3: The replacement is done on the whole JSON-like string and not on specific elements. To prevent replacement of technical informations (e.g. about "rsync") when a user do use a technical login name (e.g. "rsync") now we search for the users homepath and not only is username.
About 4: Replaced use of
os.path
with high-level APIpathlib.Path
. Also reduced "cyclomatic complexity" (was 15) ofget_diagnostics()
with moving one code part into its own private method.The output no looks like this