Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Remove "fuse" user group handling and checking #1472

Merged
merged 5 commits into from
Jul 18, 2023
Merged

feat!: Remove "fuse" user group handling and checking #1472

merged 5 commits into from
Jul 18, 2023

Conversation

buhtz
Copy link
Member

@buhtz buhtz commented Jul 13, 2023

The following behavior, introduced in 2013 via 26474f8, was removed: While installing (in configure script) and when mounting (see mount.py::MountControl.checkFuse()) the existence of the user group "fuse" was checked. The reasons and arguments described in #1450.

The exclamation mark (in "feat!:") is used even if it isn't a breaking change for real. The behavior shouldn't change because of the assumption that the code is not reached in any situation. But if the assumption is wrong it might be easier to find the relevant commit message.

Close #1450

@buhtz buhtz self-assigned this Jul 13, 2023
Copy link
Contributor

@aryoda aryoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable and good, let's remove it and wait for new issues (if any!)

@buhtz buhtz merged commit f5f19ed into bit-team:dev Jul 18, 2023
1 check passed
@buhtz buhtz deleted the refactor/1450removefusegrouphandling branch July 18, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mount.py: F821 Undefined name "grp" / Check fuse-group membership
2 participants