Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install dbus configuration file to /usr/share not /etc #1596

Merged
merged 2 commits into from
Jan 21, 2024
Merged

Conversation

Fantu
Copy link
Contributor

@Fantu Fantu commented Jan 1, 2024

This was done in Debian packages in version 1.4.1-1

From https://dbus.freedesktop.org/doc/dbus-daemon.1.html:

The standard system bus normally reads additional XML files from /usr/share/dbus-1/system.d. Third-party packages should install the default policies necessary for correct operation into that directory, which has been supported since dbus 1.10 (released in 2015).
The standard system bus normally also reads XML files from /etc/dbus-1/system.d, which should be used by system administrators if they wish to override default policies.
Third-party packages would historically install XML files into /etc/dbus-1/system.d, but this practice is now considered to be deprecated: that directory should be treated as reserved for the system administrator.

@aryoda aryoda self-requested a review January 4, 2024 02:17
@aryoda
Copy link
Contributor

aryoda commented Jan 4, 2024

Thanks a lot for your PR (and giving us the context for the dbus config location change) 😄

Please give me a few days to find and perform a test case to avoid a possible regression.

addInstallDir "/share/dbus-1/system.d"
addInstallFiles "net.launchpad.backintime*.conf" "/share/dbus-1/system.d"
addUninstallDir "/share/dbus-1"
addUninstallDir "/share"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just wondering if we still need to care about uninstalling from /etc too to avoid orphaned files in /etc if the "old" make install was used. This could lead to strange side effects if the same file exists in different versions in /etc and /share.

@aryoda aryoda merged commit 1df210c into bit-team:dev Jan 21, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants