Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output improvements #1

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Output improvements #1

merged 2 commits into from
Feb 2, 2021

Conversation

weph
Copy link
Contributor

@weph weph commented Feb 2, 2021

Hey,

I had just installed the action and let it run. It failed with "Running Infection failed! Check error output above" but there wasn't any output. I've added stdout/err to the exception message similar to how Sebastian is doing it. After changing it I discovered that the cause of the error was the -j 4 I copy/pasted from the README. It actually has to be -j4 or -j=4. I changed that in the docs and tests. It doesn't really matter for the latter but I like to keep it straight.

I also print the output of infection so the developer can see the results.

@coveralls
Copy link

coveralls commented Feb 2, 2021

Pull Request Test Coverage Report for Build 530275454

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.3%) to 96.0%

Totals Coverage Status
Change from base Build 523919552: 1.3%
Covered Lines: 24
Relevant Lines: 25

💛 - Coveralls

@shochdoerfer
Copy link
Member

@weph awesome! Thanks for your contribution. I had on my list to improve the output as well, so thanks for saving my time ;)

@shochdoerfer shochdoerfer merged commit b537ebb into bitExpert:master Feb 2, 2021
@shochdoerfer shochdoerfer added this to the 0.2.0 milestone Feb 2, 2021
@shochdoerfer
Copy link
Member

@weph Release 0.2.0 published!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants