Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless wrong error #231

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

iranimij
Copy link

@iranimij iranimij commented Apr 5, 2024

No description provided.

@iranimij
Copy link
Author

iranimij commented Apr 5, 2024

#230

@shochdoerfer
Copy link
Member

Thank you for spotting this and providing a fix!

@rikwillems WDTY?

@rikwillems
Copy link
Contributor

@iranimij @shochdoerfer this looks like a good solution for these previously existing items.

Checks are running now and I will merge it in when they succeed.

@coveralls
Copy link

Coverage Status

coverage: 58.745% (-0.1%) from 58.857%
when pulling 9b451aa on iranimij:remove-useless-wrong-error
into 760bbd3 on bitExpert:master.

@shochdoerfer
Copy link
Member

@rikwillems if you need me to craft a release, let me know. Happy to help :)

@rikwillems
Copy link
Contributor

@shochdoerfer the issues in CI are unrelated to the PR.
Shall we combine this with #233 and #234 and create a release?

@shochdoerfer
Copy link
Member

@rikwillems sounds like a plan. Should I create the release or do you want to take over?

@rikwillems rikwillems merged commit 782075a into bitExpert:master Apr 25, 2024
2 of 8 checks passed
@shochdoerfer shochdoerfer added this to the 5.4.0 milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants