Merge pull request #14 from bitExpert/feature/phpstan

Add PHPStan dependency

build.xml

@@ -10,6 +10,14 @@
         </exec>
     </target>
 
+    <target name="analyse">
+        <exec executable="./vendor/bin/phpstan"
+              passthru="true"
+              checkreturn="true">
+            <arg value="analyze"/>
+        </exec>
+    </target>
+
     <target name="lint">
         <phplint>
             <fileset dir="${phing.dir}/src">

composer.json

@@ -29,7 +29,8 @@
     "n98/magerun2": "^4.0.0",
     "phpunit/phpunit": "^9.5",
     "squizlabs/php_codesniffer": "^3.5",
-    "phing/phing": "^2.16"
+    "phing/phing": "^2.16",
+    "phpstan/phpstan": "^0.12.68"
   },
   "repositories": [
     {

phpstan.neon

@@ -0,0 +1,5 @@
+parameters:
+    level: 7
+    paths:
+        - src
+

src/BitExpert/Magento/ListApiEndpoints/Command/ListApiEndpoints.php

@@ -28,7 +28,7 @@ class ListApiEndpoints extends AbstractMagentoCommand
     /**
      * {@inheritdoc}
      */
-    protected function configure()
+    protected function configure(): void
     {
         $this
             ->setName('api:list:endpoints')
@@ -64,7 +64,9 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $this->detectMagento($output);
         if ($this->initMagento()) {
             $methodFilter = $input->getOption(self::OPTION_FILTER_METHOD);
+            $methodFilter = is_string($methodFilter) ? $methodFilter : '';
             $routeFilter = $input->getOption(self::OPTION_FILTER_ROUTE);
+            $routeFilter = is_string($routeFilter) ? $routeFilter : '';
             $services = $this->getDefinedServices();
             $services = $this->filterServices($services, $methodFilter, $routeFilter);
 
@@ -77,10 +79,12 @@ protected function execute(InputInterface $input, OutputInterface $output)
                     throw new InvalidArgumentException('Selected output-format is not a valid option');
             }
         }
+
+        return 0;
     }
 
     /**
-     * @return array
+     * @return array<string, array<string, array<string, array<string, string>>>>
      */
     protected function getDefinedServices()
     {
@@ -90,8 +94,9 @@ protected function getDefinedServices()
     }
 
     /**
-     * @param array $services
+     * @param array<string, array<string, array<string, array<string, string>>>> $services
      * @param OutputInterface $output
+     * @return void
      */
     private function printAsTable(array $services, OutputInterface $output)
     {
@@ -118,26 +123,26 @@ private function printAsTable(array $services, OutputInterface $output)
      * Remove routes from given $services array that do not match given $methodsToFilter. $methodsToFilter can
      * contain a single HTTP method like GET or POST or multiple ones separated by a comma.
      *
-     * @param array $services
+     * @param array<string, array<string, array<string, array<string, string>>>> $services
      * @param string $methodsToFilter
      * @param string $routesToFilter
-     * @return array
+     * @return array<string, array<string, array<string, array<string, string>>>>
      */
     private function filterServices(array $services, $methodsToFilter, $routesToFilter)
     {
         if (!isset($services['routes']) || !is_array($services['routes'])) {
             return $services;
         }
 
-        if (!empty($routesToFilter)) {
+        if (is_string($routesToFilter) && !empty($routesToFilter)) {
             foreach ($services['routes'] as $route => $methods) {
                 if (strpos($route, $routesToFilter) === false) {
                     unset($services['routes'][$route]);
                 }
             }
         }
 
-        if (!empty($methodsToFilter)) {
+        if (is_string($methodsToFilter) && !empty($methodsToFilter)) {
             $methodsToFilterArray = explode(',', strtoupper($methodsToFilter));
             array_walk($methodsToFilterArray, function (&$value, $index) {
                 $value = trim($value);