OP_REVERSEBYTES / BCH_2020_05 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add implementation for OP_REVERSEBYTES - Add instruction set flag for OP_REVERSEBYTES - Add new BCH_2020_05_STRICT_SPEC which includes OP_REVERSEBYTES - Add non-strict version, which uses 2019_05 (plus OP_REVERSEBYTES) rules for unit tests - Add script_tests for OP_REVERSEBYTES - Update script tests addendum
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 98.85% 98.80% -0.06%
==========================================
Files 88 88
Lines 5483 5504 +21
Branches 970 971 +1
==========================================
+ Hits 5420 5438 +18
- Misses 27 29 +2
- Partials 36 37 +1
Continue to review full report at Codecov.
|
|
@rkalis this is fantastic, thanks for the PR! Well done on updating the "addendum" too, I'm sure that was a pain. 😅 Should have a release out shortly 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
OP_REVERSEBYTESopcode to a newBCH_2020_05_STRICT_SPEC. It also updates the script_tests.json with Bitcoin-ABC'sOP_REVERSEBYTEStests. To make the script_tests work without to many changes, I also added a non-strictBCH_2020_05_SPEC, which uses the same standardness checks asBCH_2019_05(which is not strictly correct for 2020_05, since most of those stanardness checks have been incorporated into the consensus rules.