Chart data source selection

[terratec]

All data sources can be selected on-the-fly for the chart (y or y2 axis).

[mutatrum]

Can you add some screenshots?

[terratec]

Settings with source selection:

[terratec]

Fan speed and rpm (manual and PID):

[terratec]

Power, current and voltages:

Maybe the suggestedMax can be improved.

[terratec]

[mutatrum]

Thanks for the pictures, makes it a lot more clear!

Settings with source selection:

On initial though, I think the axis selection should be on the dashboard, near the graph, not in settings. Not sure how that should be UI wise.

Secondly, someone on Discord is working in the same area, but has a different direction: https://discord.com/channels/1091348375301013615/1094385595981246535/1375742408045760595

[skot]

This is awesome! But I agree the source selector should be in the chart page.

[duckaxe]

This is awesome! But I agree the source selector should be in the chart page.

I experimented with the chart display and have some suggestions. We add the two data source dropdowns (the border color is adjusted accordingly) and remove the labels from the chart (or reposition them). In dropdowns we should add an additional (empty) option (--) so that the user has the option to display only one source/axis.

[mutatrum]

One top left and the other top right, above their respective axes? No need to have the labels then.

Mock-up:

And if you're really OCD, put the caret on the left for the right axis 😆

[duckaxe]

Ah, I dont see, you uploaded a mockup ;)
I have scaled the dropdown a little, it doesn't have to be big on the dashboard.

[duckaxe]

@terratec I added my changes to the two dropdowns on the dashboard. It works fine. Just apply the attached patch file to your code. What we need is to reset the chart dataset for the changed axis. See my video at the end.

Screen.Recording.2025-05-30.at.19.46.13.mov

[terratec]

This is fantastic, thank you!

Maybe we can call initializeChart to reset? Do we have to deinit/unsubscribe first?

[duckaxe]

@terratec I tested your latest changes, it looks like the view is reloading, but the chart is still broken.

Screen.Recording.2025-05-31.at.18.20.54.mov

[terratec]

@terratec I tested your latest changes, it looks like the view is reloading, but the chart is still broken.
Screen.Recording.2025-05-31.at.18.20.54.mov

This is only a limitation with the static test data in system.service.ts.

[duckaxe]

@terratec I changed something and it looks much better without re-rendering the view. Untitled.patch

Untitled2.mov

[terratec]

@terratec I changed something and it looks much better without re-rendering the view. Untitled.patch
Untitled2.mov

With this change the previous data is missing. I think we need PR #951 and then we can also move "load previous data" into a separate function.

[duckaxe]

Ah, you right. Okay, then we'll wait for the merge.

[terratec]

@duckaxe With #996 a new subscription for this.info$ was added. It looks like the interval object now survives the optimized reload logic.
Can I fix it like this or is there a better way?
this.titleSubscription = this.info$.subscribe(info => { this.titleService.setTitle( [ ...
and in updateSystem():
... next: () => { this.titleSubscription.unsubscribe(); ...

[duckaxe]

@terratec 👍

[mutatrum]

LGTM, hope we can get this merged in the next version. Is there stull stuff to do as it's in draft?

[terratec]

What about the hashrate calculation in the frontend html? Extra Issue?

[WantClue]

What about the hashrate calculation in the frontend html? Extra Issue?

yes this should be it's own issue please.
I'm making sure to review and test this PR so that we can merge this ASAP

[duckaxe]

Why we need an unsubscribe?

[terratec]

Each source selection would add a subscription with additional data points.

[duckaxe]

terratec#1

Another idea would be to synchronize the two dropdowns. When something is selected in one dropdown, remove that entry from the other dropdown. But nice to have.

[duckaxe]

Tested on my Bitaxe. Looks 👍

[kakulukia]

Dont really know if this is the source of the problem, but as its realated i just wanted to report it here.

I installed the current git version and really like the new dashboard and also that it kinda took the freedom to auto activated data logging to not start without data to display.

But now every time i visit the settings page data logging is set to "Every 10 minutes, 28 seconds for 5 days, 5 hours, 43 minutes, 12 seconds" not respecting the previous setting.

Was that introduced with the merge of this PR or where does that actually belong to?

Another side note: The dropdown entries for switching the data source look rather random - whats the logic behind that?

[terratec]

Dont really know if this is the source of the problem, but as its realated i just wanted to report it here.

I installed the current git version and really like the new dashboard and also that it kinda took the freedom to auto activated data logging to not start without data to display.

But now every time i visit the settings page data logging is set to "Every 10 minutes, 28 seconds for 5 days, 5 hours, 43 minutes, 12 seconds" not respecting the previous setting.

Was that introduced with the merge of this PR or where does that actually belong to?

Another side note: The dropdown entries for switching the data source look rather random - whats the logic behind that?

The default value for data logging should be 0 (disabled). This seems to be an user-defined value or maybe an old value from an older test version.
First I would try setting the value to 0, clicking save and restart.

The dropdown boxes contain all available data sources from the data logging task.

[kakulukia]

Saving and restarting did not change the behaviour. Im on 1873664-dirty as i was testing the autotune feature.

Saving the 0 is respected since i dont see content in the chart right after starting, but as soon as i visit the systems settings the displayed valued is not initialized with the current value of the setting.

And my question about the dropdown content was more about: Why is it not sorted alphabetically? Its at least seems random to me if there was a reason to sort it that way: id like to know.

[terratec]

Saving and restarting did not change the behaviour. Im on 1873664-dirty as i was testing the autotune feature.

Saving the 0 is respected since i dont see content in the chart right after starting, but as soon as i visit the systems settings the displayed valued is not initialized with the current value of the setting.

And my question about the dropdown content was more about: Why is it not sorted alphabetically? Its at least seems random to me if there was a reason to sort it that way: id like to know.

Maybe it's a side effect of the merge. Have you also tested an image from the master branch?
Probably info.statsFrequency is not yet fully fixed @KillerInk
257e246

The chart is always empty after booting because RAM is used for data logging.

Ah yes the order is:

• system default values
• temperature related
• voltage related
• power related
• fan related
• system related

[kakulukia]

What about also displaying the grouping that way: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/optgroup

No, I have not yet tested the master branch. I will have another look after 2.12 is done as it's not that serious.

[terratec]

Something like this: https://v17.primeng.org/dropdown#group
Maybe create an issue?

[duckaxe]

Grouping would require quite a bit of technical restructuring (eChartLabel must become an array, the related code must be refactored). Other simple ways would be to sort the options alphabetically or use a frequency-based order (values that are rarely used are placed at the bottom).