Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] change meeting pace to 2 meetings for 1 PR monthly #692

Merged

Conversation

glozow
Copy link
Contributor

@glozow glozow commented Jun 1, 2023

Planning to switch to monthly starting August 2nd.

Implements #684.

Copy link
Contributor

@stickies-v stickies-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach ACK, sorry for the late review.

A couple of weekly references still there (diff below) and I left a few nits because why not, but overall I think this works well. We'll probably just have to run this for a few months and update the documentation based on experience wrt format etc.

Remaining weekly references:

git diff
diff --git a/code-of-conduct.md b/code-of-conduct.md
index 5a00ac6..ef07b4f 100644
--- a/code-of-conduct.md
+++ b/code-of-conduct.md
@@ -68,7 +68,7 @@ Harrassment can take many forms. Examples include, but are not limited to:
    take further action. These actions could include:
 
     - A warning
-    - Removal from the club’s channel for the duration of that week’s meeting  
+    - Removal from the club’s channel for the duration of the ongoing meeting
     - Being banned from all future club meetings 
 
 We reserve the right to reject any report we believe to have been made in bad
diff --git a/your-first-meeting.md b/your-first-meeting.md
index 5c05768..fcb06fb 100644
--- a/your-first-meeting.md
+++ b/your-first-meeting.md
@@ -9,7 +9,7 @@ If you’re thinking about attending PR Review Club, welcome! We love new
 participants. Below is information to help you get started as a first-timer.
 
 The club meets on {{ site.meeting_day }}s at {{ site.meeting_time }} in
-{{ site.meeting_location }}. Every week, a Bitcoin protocol
+{{ site.meeting_location }}. Every month, a Bitcoin protocol
 developer will host a 60-minute discussion on a Bitcoin Core pull request. [The
 code of conduct](https://bitcoincore.reviews/code-of-conduct) details the
 behavior we expect from all participants.
@@ -40,13 +40,13 @@ very casual.
 If you’d like to more actively participate, you should clone the [Bitcoin
 repository](https://github.com/bitcoin/bitcoin). You should also check out and
 build the PR branch locally and run all tests. Take time to review the code changes and
-read the comments on that week’s PR.
+read the comments on the PR being covered.
 
 There are also notes and questions you can review and prepare. Make a note
 of any questions you want to ask.
 
 The meeting will begin with **#startmeeting** and
-“hi” from that week’s host. Feel free to respond with “hi” so people know
+“hi” from the meeting host. Feel free to respond with “hi” so people know
 you’re at your keyboard and participating. The host will poll everyone on
 whether they've reviewed the PR (y/n). Don't feel embarrassed to say "n".
 
@@ -57,6 +57,6 @@ at the end of the hour. Thanking the host at the end of the meeting is always
 appreciated!
 
 Follow the [PR Review Club on Twitter](https://twitter.com/BitcoinCorePRs) for
-announcements on that week’s PR or schedule changes.
+announcements on the next PR or schedule changes.
 
 **We look forward to having you at the next PR Review Club!**

hosting.md Outdated Show resolved Hide resolved
hosting.md Outdated Show resolved Hide resolved
hosting.md Outdated Show resolved Hide resolved
index.md Outdated Show resolved Hide resolved
@stickies-v stickies-v mentioned this pull request Jun 20, 2023
@glozow glozow force-pushed the change-pace-monthly branch from 89546f1 to c868aad Compare July 6, 2023 08:21
@glozow glozow marked this pull request as ready for review July 6, 2023 08:21
Copy link
Contributor Author

@glozow glozow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch @stickies-v, I totally forgot about a few pages! Addressed comments and added you as coauthor.

@stickies-v stickies-v force-pushed the change-pace-monthly branch from c868aad to afa34dd Compare July 6, 2023 11:05
@stickies-v stickies-v force-pushed the change-pace-monthly branch from afa34dd to 3810234 Compare July 6, 2023 11:07
Copy link
Contributor

@stickies-v stickies-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for getting this ready @glozow! (just force-pushed a tiny typo and then moved it to the correct commit in another force push, because why do things right from the start if you can avoid it)

@stickies-v stickies-v merged commit 445e272 into bitcoin-core-review-club:master Jul 6, 2023
@glozow glozow deleted the change-pace-monthly branch July 6, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants