Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper bound pin on typing extensions #662

Closed
wants to merge 1 commit into from

Conversation

patrick91
Copy link

@patrick91 patrick91 commented Feb 12, 2023

Upper bounds should be done in user land :)

Should fix this issue: strawberry-graphql/strawberry#2533

Closes #572

@k9ert
Copy link
Contributor

k9ert commented Feb 13, 2023

Discussed also in #572

@achow101
Copy link
Member

setup.py is automatically generated, our dependencies are managed with poetry in pyproject.toml. Please update in there.

Upper bounds should be done in user land :)

They use semver, so that introduces the possibility of a breaking change in newer major versions, so we should upper bound on the current major version and evaluate whether new major versions are incompatible.

@k9ert
Copy link
Contributor

k9ert commented Feb 15, 2023

setup.py is automatically generated, our dependencies are managed with poetry in
pyproject.toml. Please update in there.

I've created #666
Thanks @patrick91 for your effort.
@achow101 i guess you can close this PR.

@achow101 achow101 closed this Feb 15, 2023
@patrick91 patrick91 deleted the patch-1 branch February 22, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update typing-extensions dependency
3 participants