Format BlockClock progress percentage according to the design file #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK |
johnny9
reviewed
Feb 28, 2023
There was a problem hiding this comment.
Screencast.from.02-28-23.11.44.46.webm
Appears to be some initialization issues when onboarding is skipped
diff --git a/src/qml/pages/main.qml b/src/qml/pages/main.qml
index b7786fdc0..d0cbd72b2 100644
--- a/src/qml/pages/main.qml
+++ b/src/qml/pages/main.qml
@@ -21,7 +21,7 @@ ApplicationWindow {
StackView {
id: main
- initialItem: onboardingWizard
+ initialItem: node
anchors.fill: parent
}
|
@johnny9 It seems that you're actually testing #277? The issue you're seeing in the video is that with #277, we have synced set to if verificationprogress is > 99 where what it should be set to is a check on if the node is in IBD or not. What you're seeing in the video is some new headers, but we're not in IBD, so the UI gets put in a weird place. Will Update 277. |
johnny9
suggested changes
Mar 2, 2023
jarolrod
force-pushed
the
format-blockclock-progress
branch
from
6958971 to
603d8b8
Compare
johnny9
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This formats the BlockClock's progress percentage to fit with the design file
The design file shows:
This PR implements