-
Notifications
You must be signed in to change notification settings - Fork 51
Don't use hover effects when on mobile #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@jarolrod I'm not able to reproduce the issue with the TextButton |
|
@johnny9 Press it, hold it, then let go somewhere else on the screen |
|
I think the apk maybe isn't updating from CI |
| property bool rightalign: false | ||
| padding: 15 | ||
| hoverEnabled: true | ||
| hoverEnabled: AppMode.isDesktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still seeing the issue with the TextButton, I believe this is because there is no "DEFAULT" state to return to after the "PRESSED" state on Android; and we don't see this issue on desktop so must be some API difference related to Android causing the UI issue.
something along the lines of this should do:
diff --git a/src/qml/controls/TextButton.qml b/src/qml/controls/TextButton.qml
index 0bfafecde..2d8bcf779 100644
--- a/src/qml/controls/TextButton.qml
+++ b/src/qml/controls/TextButton.qml
@@ -39,6 +39,14 @@ Button {
}
}
states: [
+ State {
+ name: "DEFAULT"; when: !root.pressed && !root.hovered
+ PropertyChanges {
+ target: root
+ textColor: root.textColor
+ bgColor: root.bgColor
+ }
+ },
State {
name: "PRESSED"; when: root.pressed
PropertyChanges {There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 405a5c8
After the recent rebase, CI is building artifacts again, and this PR now works perfectly.
8eac738 qml: setup AppMode in initerrormessage (jarolrod) Pull request description: If you run the GUI with an invalid parameter, the `initerrormessage` window should appear. But, #289 introduced a dependency on `AppMode` being available into the `OutlineButton` which the `initerrormessage` window uses. So, the following appears on master and the `initerrormessage` window does not appear: ``` $ ./src/qt/bitcoin-qt -signsadfsad Error: Cannot parse command line arguments: Invalid parameter -signsadfsad QQmlApplicationEngine failed to load component qrc:/qml/pages/initerrormessage.qml:32:9: Type OutlineButton unavailable qrc:/qml/controls/OutlineButton.qml:7:1: module "org.bitcoincore.qt" is not installed ``` This encapsulates the setting of AppMode into a function, and runs in within the `InitErrorMessageBox` function: <img width="612" alt="Screen Shot 2023-06-03 at 12 52 55 AM" src="https://github.com/bitcoin-core/gui-qml/assets/23396902/aa46d32f-855e-46b2-b219-d77319f6d492"> [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/unsecure_win_gui.zip?branch=pull/344) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/unsecure_mac_gui.zip?branch=pull/344) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/unsecure_mac_arm64_gui.zip?branch=pull/344) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/unsecure_android_apk.zip?branch=pull/344) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android32/unsecure_android_32bit_apk.zip?branch=pull/344) ACKs for top commit: johnny9: ACK 8eac738 Tree-SHA512: 24c31154ab4f7efd6b718f799bd4aafc79d56cdc4aad82a66db2d0618eaf24730c905dc8c958b44b9f90b7e9bbbccb30a717dfd7e70e2170820fa4478fac8487
7f5f34d qml: don't use hover effects when on mobile (johnny9) Pull request description: [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/unsecure_win_gui.zip?branch=pull/289) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/unsecure_mac_gui.zip?branch=pull/289) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/unsecure_mac_arm64_gui.zip?branch=pull/289) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/unsecure_android_apk.zip?branch=pull/289) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android32/unsecure_android_32bit_apk.zip?branch=pull/289) ACKs for top commit: jarolrod: ACK 7f5f34d Tree-SHA512: a0bc17ef6069d10def0c21d10205bf409a8c0f301126f5bb7dff157b1a5e04750f3d46c1ff57cbecc08ab3a90d645d8a56d7c493d7e03b40a3af64df108d90d3
96724c2 qml: setup AppMode in initerrormessage (jarolrod) Pull request description: If you run the GUI with an invalid parameter, the `initerrormessage` window should appear. But, bitcoin-core/gui-qml#289 introduced a dependency on `AppMode` being available into the `OutlineButton` which the `initerrormessage` window uses. So, the following appears on master and the `initerrormessage` window does not appear: ``` $ ./src/qt/bitcoin-qt -signsadfsad Error: Cannot parse command line arguments: Invalid parameter -signsadfsad QQmlApplicationEngine failed to load component qrc:/qml/pages/initerrormessage.qml:32:9: Type OutlineButton unavailable qrc:/qml/controls/OutlineButton.qml:7:1: module "org.bitcoincore.qt" is not installed ``` This encapsulates the setting of AppMode into a function, and runs in within the `InitErrorMessageBox` function: <img width="612" alt="Screen Shot 2023-06-03 at 12 52 55 AM" src="https://github.com/bitcoin-core/gui-qml/assets/23396902/aa46d32f-855e-46b2-b219-d77319f6d492"> [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/unsecure_win_gui.zip?branch=pull/344) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/unsecure_mac_gui.zip?branch=pull/344) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/unsecure_mac_arm64_gui.zip?branch=pull/344) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/unsecure_android_apk.zip?branch=pull/344) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android32/unsecure_android_32bit_apk.zip?branch=pull/344) ACKs for top commit: johnny9: ACK 96724c2 Tree-SHA512: 24c31154ab4f7efd6b718f799bd4aafc79d56cdc4aad82a66db2d0618eaf24730c905dc8c958b44b9f90b7e9bbbccb30a717dfd7e70e2170820fa4478fac8487
7f5f34d82b329c37c8aca63a53fac34f838c8e9a qml: don't use hover effects when on mobile (johnny9) Pull request description: [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/unsecure_win_gui.zip?branch=pull/289) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/unsecure_mac_gui.zip?branch=pull/289) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/unsecure_mac_arm64_gui.zip?branch=pull/289) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/unsecure_android_apk.zip?branch=pull/289) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android32/unsecure_android_32bit_apk.zip?branch=pull/289) ACKs for top commit: jarolrod: ACK 7f5f34d82b329c37c8aca63a53fac34f838c8e9a Tree-SHA512: a0bc17ef6069d10def0c21d10205bf409a8c0f301126f5bb7dff157b1a5e04750f3d46c1ff57cbecc08ab3a90d645d8a56d7c493d7e03b40a3af64df108d90d3
96724c29a89849a43cdfa674c19d172111bcbda2 qml: setup AppMode in initerrormessage (jarolrod) Pull request description: If you run the GUI with an invalid parameter, the `initerrormessage` window should appear. But, bitcoin-core/gui-qml#289 introduced a dependency on `AppMode` being available into the `OutlineButton` which the `initerrormessage` window uses. So, the following appears on master and the `initerrormessage` window does not appear: ``` $ ./src/qt/bitcoin-qt -signsadfsad Error: Cannot parse command line arguments: Invalid parameter -signsadfsad QQmlApplicationEngine failed to load component qrc:/qml/pages/initerrormessage.qml:32:9: Type OutlineButton unavailable qrc:/qml/controls/OutlineButton.qml:7:1: module "org.bitcoincore.qt" is not installed ``` This encapsulates the setting of AppMode into a function, and runs in within the `InitErrorMessageBox` function: <img width="612" alt="Screen Shot 2023-06-03 at 12 52 55 AM" src="https://github.com/bitcoin-core/gui-qml/assets/23396902/aa46d32f-855e-46b2-b219-d77319f6d492"> [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/unsecure_win_gui.zip?branch=pull/344) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/unsecure_mac_gui.zip?branch=pull/344) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/unsecure_mac_arm64_gui.zip?branch=pull/344) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/unsecure_android_apk.zip?branch=pull/344) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android32/unsecure_android_32bit_apk.zip?branch=pull/344) ACKs for top commit: johnny9: ACK 96724c29a89849a43cdfa674c19d172111bcbda2 Tree-SHA512: 24c31154ab4f7efd6b718f799bd4aafc79d56cdc4aad82a66db2d0618eaf24730c905dc8c958b44b9f90b7e9bbbccb30a717dfd7e70e2170820fa4478fac8487


Uh oh!
There was an error while loading. Please reload this page.