Use node model state to update the android notification #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnny9
force-pushed
the
jni-notifications
branch
2 times, most recently
from
6e0d079 to
1ef10e1
Compare
|
|
johnny9
force-pushed
the
jni-notifications
branch
2 times, most recently
from
d5411a7 to
eb53a46
Compare
|
Needs rebase. |
jarolrod
reviewed
May 31, 2023
| this, &AndroidNotifier::onBlockTipHeightChanged); | ||
| QObject::connect(&node_model, &NodeModel::numOutboundPeersChanged, | ||
| this, &AndroidNotifier::onNumOutboundPeersChanged); | ||
| QObject::connect(&node_model, &NodeModel::pauseChanged, |
There was a problem hiding this comment.
Concept ACK, I've been running and testing this for a few days. The only issue I've noticed is that the "Paused" state won't be represented in the Notification if we were syncing before pressing paused. If we were connecting or any other state, it'll show. But not if we were syncing.
There was a problem hiding this comment.
What state does it show? I'm having a hard time reproducing
There was a problem hiding this comment.
Well now I also can't reproduce, may have just lagged in showing the update for whatever reason android decided.
| notificationBuilder.setContentTitle("Connecting..."); | ||
| } else if (!synced) { | ||
| if (verificationProgress < 0) { | ||
| notificationBuilder.setContentTitle(String.format("%.2f%% loaded...", verificationProgress)); |
There was a problem hiding this comment.
johnny9
force-pushed
the
jni-notifications
branch
from
eb53a46 to
acd2d3e
Compare
The AndroidNotifier class connects to the NodeModel's state signals and uses JNI to send callbacks to the Android service managing the foreground notification.
johnny9
force-pushed
the
jni-notifications
branch
from
acd2d3e to
b641df4
Compare
jarolrod
reviewed
Jun 2, 2023
There was a problem hiding this comment.
Approach ACK
I've been learning more about what we really need to do here in order to interact with the Android and the JVM, and this code is looking good here.
The androidnotifier.cpp file contains the importance pieces of magic. We're gaining access to the JVM and storing it. Then we're setting up the wiring between nodeModel updates to calls into our BitcoinQt Service to update the notification text.
@johnny9 are you able to reproduce this: https://github.com/bitcoin-core/gui-qml/pull/331/files#r1211573422
jarolrod
approved these changes
Jun 3, 2023
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
…droid notification 50c7340 android: use node model state to update notification (johnny9) Pull request description: The AndroidNotifier class connects to the NodeModel's state signals and uses JNI to send callbacks to the Android service managing the foreground notification. [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/unsecure_win_gui.zip?branch=pull/331) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/unsecure_mac_gui.zip?branch=pull/331) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/unsecure_mac_arm64_gui.zip?branch=pull/331) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/unsecure_android_apk.zip?branch=pull/331) ACKs for top commit: jarolrod: ACK 50c7340 Tree-SHA512: 1dfc95ade573f6620ba67871ff6f609e4bffe4cee877e03bd56c8917ac8cfb184198e5ca603ffda1962a3416da52921c0228eab5f0172011eca44de3d813e0d0
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
…droid notification 50c73409abb042fb20f00d803aee082981425398 android: use node model state to update notification (johnny9) Pull request description: The AndroidNotifier class connects to the NodeModel's state signals and uses JNI to send callbacks to the Android service managing the foreground notification. [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/unsecure_win_gui.zip?branch=pull/331) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/unsecure_mac_gui.zip?branch=pull/331) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/unsecure_mac_arm64_gui.zip?branch=pull/331) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/unsecure_android_apk.zip?branch=pull/331) ACKs for top commit: jarolrod: ACK 50c73409abb042fb20f00d803aee082981425398 Tree-SHA512: 1dfc95ade573f6620ba67871ff6f609e4bffe4cee877e03bd56c8917ac8cfb184198e5ca603ffda1962a3416da52921c0228eab5f0172011eca44de3d813e0d0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AndroidNotifier class connects to the NodeModel's state signals and uses JNI to send callbacks to the Android service managing the foreground notification.