Migrate to PageStacks #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarolrod
force-pushed
the
pagestack-migration
branch
from
0d7c1ab to
3788060
Compare
pablomartin4btc
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
tACK 3788060
Nice job! Removing dependencies with ids outside a page was almost mandatory, this avoids unexpected crashes when things change outside the page and can't be noticed. We need to add a hook or a test that evaluates the existence of views we are moving to onNext: and warns if there are components that are not/ (or left un-) referenced.
Comment on lines
131
to
133
| onBack: { | ||
| nodeSettingsView.pop() | ||
| } |
There was a problem hiding this comment.
nit: as in other places in the same file...
Suggested change
| onBack: { | |
| nodeSettingsView.pop() | |
| } | |
| onBack: nodeSettingsView.pop() |
There was a problem hiding this comment.
a note for the style guide
Comment on lines
163
to
165
| onBack: { | ||
| nodeSettingsView.pop() | ||
| } |
Introduces a custom PageStack control that is a StackView adapted for our use in terms of the custom animations we demand, and the ability to switch between vertical and horizontal push() and pop(). This can later be further extended for our use cases.
This should be encapsulated so it can be reasoned about independently and in a well defined location. Additionally, swap from SwipeView to PageStack.
Vertical PageStacks used to replace vertical SwipeViews.
jarolrod
force-pushed
the
pagestack-migration
branch
from
3788060 to
c52566d
Compare
MarnixCroes
approved these changes
Nov 12, 2024
D33r-Gee
reviewed
Nov 12, 2024
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: there are extra blank lines
johnny9
approved these changes
Nov 12, 2024
1 task
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
edc44e1 qml: Swap existing SwipeViews for PageStack (jarolrod) 825b883 qml: Swap existing StackViews for PageStack (jarolrod) 9c02a20 qml: declare OnboardingWizard file, reintroduce as PageStack (jarolrod) 51b1273 qml: Introduce PageStack control (jarolrod) Pull request description: After fixing our sins in bitcoin-core/gui-qml#427, migrating to A StackView based GUI is quite simple. Here we use a custom StackView control, PageStack, that has a property `vertical` used to declare if we want vertical or horizontal animations, and additionally implements the [custom animation](bitcoin-core/gui-qml#422) we want. Closes bitcoin-core/gui-qml#422 Closes bitcoin-core/gui-qml#219 []() ACKs for top commit: pablomartin4btc: re-ACK edc44e1 MarnixCroes: tACK edc44e1 D33r-Gee: tACK [edc44e1](bitcoin-core/gui-qml@edc44e1) Works as expected on WSL Ubuntu 22.04 johnny9: ACK edc44e1 Tree-SHA512: f9a025944db24a46e1f78f4ad8a9b9aca4e1f3ff4dd5927eebfa2a7fb28ed390a17da79e23c6248c3c0e82b361ff1b2dedbf4df9df2a1d0677b05bacb7763bcb
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
edc44e1ef1becfb7ee753bd8dd8b5663d39ecf41 qml: Swap existing SwipeViews for PageStack (jarolrod) 825b883269ae3f05a59977010c81af6ecad8f4e8 qml: Swap existing StackViews for PageStack (jarolrod) 9c02a20ba1b13e4874be5009077e6513db0790db qml: declare OnboardingWizard file, reintroduce as PageStack (jarolrod) 51b1273ba151ce7ac2eb00a94b4e3dc7528c3e17 qml: Introduce PageStack control (jarolrod) Pull request description: After fixing our sins in bitcoin-core/gui-qml#427, migrating to A StackView based GUI is quite simple. Here we use a custom StackView control, PageStack, that has a property `vertical` used to declare if we want vertical or horizontal animations, and additionally implements the [custom animation](bitcoin-core/gui-qml#422) we want. Closes bitcoin-core/gui-qml#422 Closes bitcoin-core/gui-qml#219 []() ACKs for top commit: pablomartin4btc: re-ACK edc44e1ef1becfb7ee753bd8dd8b5663d39ecf41 MarnixCroes: tACK edc44e1ef1becfb7ee753bd8dd8b5663d39ecf41 D33r-Gee: tACK [edc44e1](bitcoin-core/gui-qml@edc44e1) Works as expected on WSL Ubuntu 22.04 johnny9: ACK edc44e1ef1becfb7ee753bd8dd8b5663d39ecf41 Tree-SHA512: f9a025944db24a46e1f78f4ad8a9b9aca4e1f3ff4dd5927eebfa2a7fb28ed390a17da79e23c6248c3c0e82b361ff1b2dedbf4df9df2a1d0677b05bacb7763bcb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After fixing our sins in #427, migrating to A StackView based GUI is quite simple.
Here we use a custom StackView control, PageStack, that has a property
verticalused to declare if we want vertical or horizontal animations, and additionally implements the custom animation we want.Closes #422
Closes #219