qt: Add "Copy address" item to the context menu in the Peers table

bitcoin-core · Mar 30, 2021 · 03a2b74 · 03a2b74
1 parent b1ab2d1
commit 03a2b74
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/src/qt/peertablemodel.cpp b/src/qt/peertablemodel.cpp
@@ -195,12 +195,26 @@ QVariant PeerTableModel::data(const QModelIndex &index, int role) const
         assert(false);
     } else if (role == StatsRole) {
         switch (index.column()) {
-        case NetNodeId: return QVariant::fromValue(rec);
-        default: return QVariant();
-        }
+        case NetNodeId:
+            return QVariant::fromValue(rec);
+        case Address:
+            return QString::fromStdString(rec->nodeStats.addrName);
+        case ConnectionType:
+            [[fallthrough]];
+        case Network:
+            [[fallthrough]];
+        case Ping:
+            [[fallthrough]];
+        case Sent:
+            [[fallthrough]];
+        case Received:
+            [[fallthrough]];
+        case Subversion:
+            return {};
+        } // no default case, so the compiler can warn about missing cases
     }
 
-    return QVariant();
+    return {};
 }
 
 QVariant PeerTableModel::headerData(int section, Qt::Orientation orientation, int role) const

diff --git a/src/qt/rpcconsole.cpp b/src/qt/rpcconsole.cpp
@@ -618,6 +618,10 @@ void RPCConsole::setClientModel(ClientModel *model, int bestblock_height, int64_
 
         // create peer table context menu
         peersTableContextMenu = new QMenu(this);
+        peersTableContextMenu->addAction(tr("Copy address"), [this] {
+            GUIUtil::copyEntryData(ui->peerWidget, PeerTableModel::Address, PeerTableModel::StatsRole);
+        });
+        peersTableContextMenu->addSeparator();
         peersTableContextMenu->addAction(tr("Disconnect"), this, &RPCConsole::disconnectSelectedNode);
         peersTableContextMenu->addAction(ts.ban_for + " " + tr("1 hour"), [this] { banSelectedNode(60 * 60); });
         peersTableContextMenu->addAction(ts.ban_for + " " + tr("1 day"), [this] { banSelectedNode(60 * 60 * 24); });