qt: connection type translator comments

Introduce Qt translator comments for connection types.

src/qt/guiutil.cpp

@@ -671,14 +671,26 @@ QString ConnectionTypeToQString(ConnectionType conn_type, bool prepend_direction
 {
  QString prefix;
  if (prepend_direction) {
- prefix = (conn_type == ConnectionType::INBOUND) ? QObject::tr("Inbound") : QObject::tr("Outbound") + " ";
+ prefix = (conn_type == ConnectionType::INBOUND) ?
+ /*: An inbound connection from a peer. An inbound connection
+ is a connection initated by a peer. */
+ QObject::tr("Inbound") :
+ /*: An outbound connection to a peer. An outbound connection
+ is a connection initiated by us. */
+ QObject::tr("Outbound") + " ";
  }
  switch (conn_type) {
  case ConnectionType::INBOUND: return prefix;
+ //: Peer connection type which relays all network information.
  case ConnectionType::OUTBOUND_FULL_RELAY: return prefix + QObject::tr("Full Relay");
+ /*: Peer connection type which relays relays network information about
+ blocks and not transactions or addresses. */
  case ConnectionType::BLOCK_RELAY: return prefix + QObject::tr("Block Relay");
+ //: Peer connection type established manually through one of several methods.
  case ConnectionType::MANUAL: return prefix + QObject::tr("Manual");
+ //: Peer connection type which verifies or tests known addresses for validity.
  case ConnectionType::FEELER: return prefix + QObject::tr("Feeler");
+ //: Peer connection type which solicits known addresses from a peer.
  case ConnectionType::ADDR_FETCH: return prefix + QObject::tr("Address Fetch");
  } // no default case, so the compiler can warn about missing cases
  assert(false);

src/qt/rpcconsole.cpp

@@ -471,14 +471,28 @@ RPCConsole::RPCConsole(interfaces::Node& node, const PlatformStyle *_platformSty
 
  constexpr QChar nonbreaking_hyphen(8209);
  const std::vector<QString> CONNECTION_TYPE_DOC{
+ //: Explanatory text for an inbound peer connection.
  tr("Inbound: initiated by peer"),
+ /*: Explanatory text for an outbound peer connection which
+ relays all network information. This is the default behavior for
+ Outbound connections. */
  tr("Outbound Full Relay: default"),
+ /*: Explanatory text for an outbound peer connection which relays
+ network information about blocks and not transactions or addresses. */
  tr("Outbound Block Relay: does not relay transactions or addresses"),
+ /*: Explanatory text for an outbound peer connection which was
+ established manually through one of several methods. The numbered
+ arguments are stand-ins for the methods available to establish
+ manual connections. */
  tr("Outbound Manual: added using RPC %1 or %2/%3 configuration options")
  .arg("addnode")
  .arg(QString(nonbreaking_hyphen) + "addnode")
  .arg(QString(nonbreaking_hyphen) + "connect"),
+ /*: Explanatory text for a temporary outbound peer connection which
+ is used to test the validity of known addresses. */
  tr("Outbound Feeler: short-lived, for testing addresses"),
+ /*: Explanatory text for a temporary outbound peer connection which is used
+ to request addresses from a peer. */
  tr("Outbound Address Fetch: short-lived, for soliciting addresses")};
  const QString list{"<ul><li>" + Join(CONNECTION_TYPE_DOC, QString("</li><li>")) + "</li></ul>"};
  ui->peerConnectionTypeLabel->setToolTip(ui->peerConnectionTypeLabel->toolTip().arg(list));