net: add CNode::IsInboundOnion() public getter and unit tests

bitcoin-core · Dec 17, 2020 · 86c4952 · 86c4952
1 parent 6609eb8
commit 86c4952
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/net.h b/src/net.h
@@ -1234,6 +1234,9 @@ class CNode
  void MaybeSetAddrName(const std::string& addrNameIn);
 
  std::string ConnectionTypeAsString() const;
+
+ /** Whether this peer is an inbound onion, e.g. connected via our Tor onion service. */
+ bool IsInboundOnion() const { return m_inbound_onion; }
 };
 
 /** Return a timestamp in the future (in microseconds) for exponentially distributed events. */

diff --git a/src/test/net_tests.cpp b/src/test/net_tests.cpp
@@ -200,6 +200,7 @@ BOOST_AUTO_TEST_CASE(cnode_simple_test)
  BOOST_CHECK(pnode1->IsFeelerConn() == false);
  BOOST_CHECK(pnode1->IsAddrFetchConn() == false);
  BOOST_CHECK(pnode1->IsInboundConn() == false);
+ BOOST_CHECK(pnode1->IsInboundOnion() == false);
  BOOST_CHECK_EQUAL(pnode1->ConnectedThroughNetwork(), Network::NET_IPV4);
 
  std::unique_ptr<CNode> pnode2 = MakeUnique<CNode>(
@@ -214,6 +215,7 @@ BOOST_AUTO_TEST_CASE(cnode_simple_test)
  BOOST_CHECK(pnode2->IsFeelerConn() == false);
  BOOST_CHECK(pnode2->IsAddrFetchConn() == false);
  BOOST_CHECK(pnode2->IsInboundConn() == true);
+ BOOST_CHECK(pnode2->IsInboundOnion() == false);
  BOOST_CHECK_EQUAL(pnode2->ConnectedThroughNetwork(), Network::NET_IPV4);
 
  std::unique_ptr<CNode> pnode3 = MakeUnique<CNode>(
@@ -228,6 +230,7 @@ BOOST_AUTO_TEST_CASE(cnode_simple_test)
  BOOST_CHECK(pnode3->IsFeelerConn() == false);
  BOOST_CHECK(pnode3->IsAddrFetchConn() == false);
  BOOST_CHECK(pnode3->IsInboundConn() == false);
+ BOOST_CHECK(pnode3->IsInboundOnion() == false);
  BOOST_CHECK_EQUAL(pnode3->ConnectedThroughNetwork(), Network::NET_IPV4);
 
  std::unique_ptr<CNode> pnode4 = MakeUnique<CNode>(
@@ -242,6 +245,7 @@ BOOST_AUTO_TEST_CASE(cnode_simple_test)
  BOOST_CHECK(pnode4->IsFeelerConn() == false);
  BOOST_CHECK(pnode4->IsAddrFetchConn() == false);
  BOOST_CHECK(pnode4->IsInboundConn() == true);
+ BOOST_CHECK(pnode4->IsInboundOnion() == true);
  BOOST_CHECK_EQUAL(pnode4->ConnectedThroughNetwork(), Network::NET_ONION);
 }