test, fuzz: fix constructing CNode with invalid inbound_onion

as CNode ctor should only be passed inbound_onion = true when the connection is inbound
bitcoin-core · Dec 17, 2020 · 993d1ec · 993d1ec
1 parent b7136c1
commit 993d1ec
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/test/fuzz/util.h b/src/test/fuzz/util.h
@@ -298,7 +298,7 @@ CNode ConsumeNode(FuzzedDataProvider& fuzzed_data_provider) noexcept
  const CAddress addr_bind = ConsumeAddress(fuzzed_data_provider);
  const std::string addr_name = fuzzed_data_provider.ConsumeRandomLengthString(64);
  const ConnectionType conn_type = fuzzed_data_provider.PickValueInArray({ConnectionType::INBOUND, ConnectionType::OUTBOUND_FULL_RELAY, ConnectionType::MANUAL, ConnectionType::FEELER, ConnectionType::BLOCK_RELAY, ConnectionType::ADDR_FETCH});
- const bool inbound_onion = fuzzed_data_provider.ConsumeBool();
+ const bool inbound_onion{conn_type == ConnectionType::INBOUND ? fuzzed_data_provider.ConsumeBool() : false};
  return {node_id, local_services, my_starting_height, socket, address, keyed_net_group, local_host_nonce, addr_bind, addr_name, conn_type, inbound_onion};
 }
 

diff --git a/src/test/net_tests.cpp b/src/test/net_tests.cpp
@@ -221,7 +221,7 @@ BOOST_AUTO_TEST_CASE(cnode_simple_test)
  /* nKeyedNetGroupIn = */ 0,
  /* nLocalHostNonceIn = */ 0,
  CAddress(), pszDest, ConnectionType::OUTBOUND_FULL_RELAY,
- /* inbound_onion = */ true);
+ /* inbound_onion = */ false);
  BOOST_CHECK(pnode3->IsFullOutboundConn() == true);
  BOOST_CHECK(pnode3->IsManualConn() == false);
  BOOST_CHECK(pnode3->IsBlockOnlyConn() == false);