Peer address column sorting does not honor the inbound/outbound arrow prefix

[ghost]

See this peer address column:

Expected behavior
Peer number 196 is sorted below peer number 424, because it is sorted by the first character (arrow) first.

Actual behavior
Peer number 196 is sorted below peer number 110. The first (arrow) character seems not to be relevant for sorting?

To reproduce
Run with both Onion and I2P network enabled and watch the peer table.

System information
22.0rc2
Debian Buster amd_64

[hebasto]

@wodry
Is this sorting order was restored from the previous Bitcoin Core run, or was set manually in the current session?

UPDATE: see #397 (comment)

[hebasto]

@wodry
Does sorting work for you without 986bf78?

UPDATE: see #397 (comment)

[ghost]

I wanted to sort by peer address (to more easily count I2P and Onion inbound/outbound connections), so I clicked manually on the peer address column header (where the little triangle is), to be sure, sorting by address is active. Then I noticed this issue. Clicking more times on the header reverses sorting order as expected, but issue persists.

[hebasto]

For now, only address itself in considered during sorting:

gui/src/qt/peertablesortproxy.cpp

Lines 27 to 28 in 03826ae

	case PeerTableModel::Address:
	return left_stats.addrName.compare(right_stats.addrName) < 0;

I wanted to sort by peer address (to more easily count inbound/outbound connections), so I clicked manually on the peer address column header (where the little triangle is), to be sure, sorting by address is active. Then I noticed this issue. Clicking more times on the header reverses sorting order as expected, but issue persists.

Maybe you could be interested in #317 or #363?

[ghost]

Maybe you could be interested in #317 or #363?

I do not find them reasonable, see my expressions there.

I like the sorting functionality that honors the inbound/outbound arrow prefix. I cannot imagine any use case for not honoring the prefix. Honoring the prefix makes sense, see my use case.

Was the prefix sorting honoring removed? In the past I did not stumble upon this issue, but not sure if I tested it explicitly.

[hebasto]

I like the sorting functionality that honors the inbound/outbound arrow prefix. I cannot imagine any use case for not honoring the prefix. Honoring the prefix makes sense, see my use case.

... to more easily count I2P and Onion inbound/outbound connections

Your use case, actually, requires filtering :)

Was the prefix sorting honoring removed?

The implementation remains unchanged since it was introduced in bitcoin/bitcoin#4225.

[ghost]

This issue would be obsoleted by alternatives like #401 (B.2) or (B.3)

[hebasto]

Closing, as #317 has been merged.