Drop buggy TableViewLastColumnResizingFixer class #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Qt 5 the last column resizing with dragging its left edge works out-of-the-box. The current TableViewLastColumnResizingFixer implementation could put the last column content out of the view port and confuse a user.
jarolrod
reviewed
Feb 8, 2021
There was a problem hiding this comment.
ACK 3913d1e, tested on macOS 11.1 Qt 5.15.2
On master, when you resize, the last column can go out of the view-port. This can be confusing because there's no contextual clues that there is more to see by scrolling to the right. This PR add this contextual awareness by showing a scrollbar. Below are screenshots showing this behavior:
Master: Last column can go out of view port while resizing
PR: scrollbar gives contextual awareness that I can scroll right to see more
promag
reviewed
Feb 21, 2021
| tableView->setModel(_model->getRecentRequestsTableModel()); | ||
| tableView->setAlternatingRowColors(true); | ||
| tableView->setSelectionBehavior(QAbstractItemView::SelectRows); | ||
| tableView->setSelectionMode(QAbstractItemView::ContiguousSelection); | ||
| tableView->setColumnWidth(RecentRequestsTableModel::Date, DATE_COLUMN_WIDTH); | ||
| tableView->setColumnWidth(RecentRequestsTableModel::Label, LABEL_COLUMN_WIDTH); | ||
| tableView->setColumnWidth(RecentRequestsTableModel::Amount, AMOUNT_MINIMUM_COLUMN_WIDTH); | ||
| tableView->horizontalHeader()->setMinimumSectionSize(MINIMUM_COLUMN_WIDTH); |
There was a problem hiding this comment.
I've removed this and didn't notice differences, at least on macos.
There was a problem hiding this comment.
It prevents
at least on Linux :)
maflcko
pushed a commit
that referenced
this pull request
Feb 22, 2021
…s column sizes 964885d qt: Save/restore recentRequestsView table column sizes (Hennadii Stepanov) f5c8093 qt: Move recentRequestsView properties settings to constructor (Hennadii Stepanov) 9c5f4f2 qt: Save/restore TransactionView table column sizes (Hennadii Stepanov) 788205c qt: Move transactionView properties settings to constructor (Hennadii Stepanov) ecdbaf7 qt, refactor: Drop intermediate assignment (Hennadii Stepanov) Pull request description: Save/restore TransactionView and recentRequestsView tables column sizes. Sorting order is not saved/restored intentionally. Based on #204 (the first commit). ACKs for top commit: jarolrod: ACK 964885d, tested on macOS 11.1 Qt 5.15.2 Talkless: tACK 964885d, tested on Debian Sid, saving/restoring and resetting (with `-resetguisettings`) works as expected. Tree-SHA512: c24e41bf4d95bb33dce16e9a0b952ffd0912e95f4d2a1bc5292fcf5a27100e70fea73433c4ff246d05b174fc23a7b6de1790a2e8b990a9089e4deca79a00dedc
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 22, 2021
…er class 3913d1e qt: Drop buggy TableViewLastColumnResizingFixer class (Hennadii Stepanov) Pull request description: In Qt 5 the last column resizing with dragging its left edge works out-of-the-box. The current `TableViewLastColumnResizingFixer` implementation could put the last column content out of the view port and confuse a user:  Historical context: - bitcoin#2862 - bitcoin#3626 - bitcoin#3738 - bitcoin#3920 #205 is a nice addition. ACKs for top commit: jarolrod: ACK 3913d1e, tested on macOS 11.1 Qt 5.15.2 Talkless: tACK 3913d1e, tested on Debian Sid. Can confirm that behavior in previous commit does not produce scroll bar, last column gets "hidden". This PR makes clear that there's more to see in the view. promag: Tested ACK 3913d1e on macos. Tree-SHA512: 12582dfce54bb1db3d9934ae092e305d32e9760cc99b0265322e161fa7f54b7d6fb6cefedf700783f767d5c3a56a8545c8d2f5ade66596c4e67b8a5287063e8a
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 28, 2022
Some GUI changes that conflict with commented-out code. I made an educated guess as to what new stuff should be commented out or not but honestly I have no idea what the GUI is supposed to do or show.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Qt 5 the last column resizing with dragging its left edge works out-of-the-box.
The current
TableViewLastColumnResizingFixerimplementation could put the last column content out of the view port and confuse a user:Historical context:
#205 is a nice addition.