qt: Re-add and rename transaction "Edit Label" action#223
Merged
maflcko merged 2 commits intobitcoin-core:masterfrom Feb 25, 2021
Merged
qt: Re-add and rename transaction "Edit Label" action#223maflcko merged 2 commits intobitcoin-core:masterfrom
maflcko merged 2 commits intobitcoin-core:masterfrom
Conversation
This reverts commit 8f96448.
Contributor
|
I have little opinion on whether the functionality should exist at all, but I think the original change was motivated by confusion about what the feature does. Just renaming it to "Change address label" would mitigate that just as well. |
Member
Author
Sounds good to me, I can include that change here if there's agreement on that. |
Member
|
Original suggestions:
I like this suggestion. |
Contributor
This is good, keeps the functionality while being more informative as to the outcome. Very democratic :) |
This makes it more specific what the action refers to. (Suggested by Pieter Wuille)
laanwj
changed the title
Member
|
Concept ACK, thanks |
Contributor
|
(edited OP before merge to remove |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 25, 2021
…abel" action 5440c07 qt: Rename "Edit label" to "Edit address label" (Wladimir J. van der Laan) 22664d6 Revert "qt: Remove Transactionview Edit Label Action" (Wladimir J. van der Laan) Pull request description: This reverts PR #211. I disagree with this change, I use the functionality a lot, it was the primary way I used to organize and edit transactions labels and am sad to see this go. > you can edit a sending address in the send tab Address Book Using the address book should not be encouraged at all! A while ago it was even proposed to remove it. There's rarely need to scroll through all historical addresses used and unused. The transaction list does just fine for this. > While all other actions apply directly to the selected transaction, the Edit Label action applies to the selected transaction's address. **In practice** when bitcoin is used in the commonly advised way, generate a new address for each transaction, those are equivalent though. I doubt I (and **luke-jr**) will be the only users that will stumblle on this. Further discussion here: bitcoin-core/gui#211 (comment) ACKs for top commit: hebasto: ACK 5440c07, verified that 22664d6 is a clean revert of 8f96448. Tree-SHA512: 3a86a730279bc454d0bd25d874dbfb6b1c0492480e66c3164e7c60d8658d622d4522de11bf8564876dc3ee056b53db71ecbe8a37281bf25d41a27e6e0d72ad8f
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 19, 2021
…abel" action 5440c07 qt: Rename "Edit label" to "Edit address label" (Wladimir J. van der Laan) 22664d6 Revert "qt: Remove Transactionview Edit Label Action" (Wladimir J. van der Laan) Pull request description: This reverts PR dashpay#211. I disagree with this change, I use the functionality a lot, it was the primary way I used to organize and edit transactions labels and am sad to see this go. > you can edit a sending address in the send tab Address Book Using the address book should not be encouraged at all! A while ago it was even proposed to remove it. There's rarely need to scroll through all historical addresses used and unused. The transaction list does just fine for this. > While all other actions apply directly to the selected transaction, the Edit Label action applies to the selected transaction's address. **In practice** when bitcoin is used in the commonly advised way, generate a new address for each transaction, those are equivalent though. I doubt I (and **luke-jr**) will be the only users that will stumblle on this. Further discussion here: bitcoin-core/gui#211 (comment) ACKs for top commit: hebasto: ACK 5440c07, verified that 22664d6 is a clean revert of 8f96448. Tree-SHA512: 3a86a730279bc454d0bd25d874dbfb6b1c0492480e66c3164e7c60d8658d622d4522de11bf8564876dc3ee056b53db71ecbe8a37281bf25d41a27e6e0d72ad8f
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts PR #211.
I disagree with this change, I use the functionality a lot, it was the primary way I used to organize and edit transactions labels and am sad to see this go.
Using the address book should not be encouraged at all! A while ago it was even proposed to remove it. There's rarely need to scroll through all historical addresses used and unused. The transaction list does just fine for this.
In practice when bitcoin is used in the commonly advised way, generate a new address for each transaction, those are equivalent though.
I doubt I (and luke-jr) will be the only users that will stumblle on this. Further discussion here: #211 (comment)