qt test: Don't bind to regtest port #233
Conversation
There was a problem hiding this comment.
ACK a9d1ddd
Confirming the behavior cited in #10 on master. Also confirming that this PR fixes it.
Tested on macOS 11.2 Qt 5.15.2 using the QT_QPA_PLATFORM=cocoa ./test_bitcoin-qt work around.
I setup a node running bitcoin-qt -regtest, then setup two instances of the test to run at the same time. Everything ran smoothly and the blocking behavior was not encountered.
|
I think this change prevents an opportunity to test Qt signals and UI response when new block/tx arrives. (that, of course, will require to spin up another node) |
The qt tests don't need to bind to the regtest port. By not binding, it will no longer conflict with existing regtest instances and the tests will run as normal.
achow101
force-pushed
the
qttest-other-port
branch
from
a9d1ddd to
e21276a
Compare
In that case, |
|
cr ACK e21276a didn't test |
| @@ -54,6 +54,13 @@ int main(int argc, char* argv[]) | |||
|
|
|||
| NodeContext node_context; | |||
| std::unique_ptr<interfaces::Node> node = interfaces::MakeNode(&node_context); | |||
| gArgs.ForceSetArg("-listen", "0"); | |||
There was a problem hiding this comment.
Passing 0 to port lets the system assign a free port number. This fixes the issue while allowing for future GUI tests that involve interactions with another node.
| gArgs.ForceSetArg("-listen", "0"); | |
| gArgs.ForceSetArg("-port", "0"); |
There was a problem hiding this comment.
I don't think that is necessary at this time. Additionally, I don't think doing this would be useful. In this hypothetical test, the test framework needs to know what port is being used, so I don't think this would help.
e21276a qt test: Don't bind to regtest port (Andrew Chow) Pull request description: The qt tests don't need to bind to the regtest port. By not binding, it will no longer conflict with existing regtest instances and the tests will run as normal. Fixes #10 ACKs for top commit: MarcoFalke: cr ACK e21276a jarolrod: re-ACK e21276a, tested on macOS 11.2 Tree-SHA512: 5a269ee043f9aff7900e092c166de71912a2bf86ebe2982b3fb0e26bdebfb91869ee5d0f62082fd608c1288bfb7981f6c8647e504b11176711d7fec993a09164
The qt tests don't need to bind to the regtest port. By not binding, it will no longer conflict with existing regtest instances and the tests will run as normal.
Fixes #10