Support runtime appearance adjustment on macOS #275

hebasto · 2021-04-09T06:35:11Z

On macOS switching appearance (Light -> Dark or Dark -> Light) when Bitcoin Core is running makes the GUI pretty unusable.
This bug is especially important when a user chose the "Auto" mode to adjust appearance automatically.

This PR fixes Bitcoin Core behavior.

This is an alternative to #268.

hebasto · 2021-04-09T06:44:42Z

@goums @jarolrod

Do you mind testing this PR?

RandyMcMillan · 2021-04-19T20:53:26Z

Concept ACK 3696ebc

Wow! Looks great!

MacOS 10.14.6 (18G8022) Light Theme

MacOS 10.14.6 (18G8022) Dark Theme

RandyMcMillan · 2021-04-19T21:06:47Z

This window should probably be aware of the color scheme as well...

hebasto · 2021-04-19T21:25:58Z

This window should probably be aware of the color scheme as well...

Leaving it as is because have no nice design solution for now.

RandyMcMillan · 2021-04-19T21:33:12Z

Concerning Accessibility: Using Accessibility Inspector on MacOS...

When inverting colors - the warning doesn't have enough contrast. Maybe in a follow up this can be addressed.

jarolrod

Concept ACK

Spent all day playing around with this and have some findings. These are the main points summarized:

The State of macOS Dark Mode Support:

This PR does allow for runtime appearance adjustment
Dark mode does not work when compiled through depends natively on macOS 11 and 10.15. It does work on macOS 10.14 (out of scope of this PR)
The Linux cross-compiles work, this is important as the release binaries are cross-compiled from linux
- There is a weird bug with rows in a table, they have their borders colored in white when in dark mode.
The macOS tool bump would break dark mode again (out of scope of this PR)

What this PR should fix:

Should fix the bug with tables when cross-compiled from linux

Below are pictures of this PR [natively compiled, native depends, cross-compile, cross-compile with macOS toolchain bump (19817)] on macOS [10.14, 10.15, 11]

macOS 10.14 Mojave

Native Compile

Start: Dark Mode	Switch: Light Mode

Native Depends Build

Start: Dark Mode	Switch: Light Mode

Linux Cross-Compile for macOS

Start: Dark Mode	Switch: Light Mode

This PR + macOS Toolchain Bump

Start: Dark Mode	Switch: Light Mode

macOS 10.15 Catalina

Native Compile

Start: Dark Mode	Switch: Light Mode

Native Depends Build

Start: Dark Mode	Switch: Light Mode

Linux Cross-Compile for macOS

Start: Dark Mode	Switch: Light Mode

This PR + macOS Toolchain Bump

Start: Dark Mode	Switch: Light Mode

macOS 11 Big Sur

Native Compile

Start: Dark Mode	Switch: Light Mode

Native Depends Build

Start: Dark Mode	Switch: Light Mode

Linux Cross-Compile for macOS

Start: Dark Mode	Switch: Light Mode

This PR + macOS Toolchain Bump

Start: Dark Mode	Switch: Light Mode

hebasto · 2021-04-20T16:29:02Z

@RandyMcMillan

Concerning Accessibility: Using Accessibility Inspector on MacOS...

Accessibility is out of this PR scope, as its only goal is the smooth runtime switching between dark and light appearances (note that the dark appearance is supported since #154).

I'll be happy to review dedicated prs that improves accessibility. Probably, it'd be nice to start from some kind of a design guide.

hebasto · 2021-04-20T16:37:28Z

@jarolrod

Spent all day playing around with this and have some findings.

Many thanks for your extensive testing and reviewing!

Dark mode does not work when compiled through depends natively on macOS 11 and 10.15. It does work on macOS 10.14 (out of scope of this PR)

Sorry, still investigating this weird issue.

There is a weird bug with rows in a table, they have their borders colored in white when in dark mode.

Is this our bug or Qt's one (upstream)? Is this bug of the switching between modes? Or it was present in #154?

promag

Quickly tested ACK 5737301. I've tested this rebased with bitcoin/bitcoin#21793.

This change is a prerequisite to support changeable appearance on macOS.

This change fixes the GUI when changing appearance on macOS.

The ThemedLabel class correctly handles appearance changes on macOS.

This change fixes the GUI when changing appearance on macOS.

hebasto · 2021-05-01T12:23:29Z

Rebased 5737301 -> c231254 (pr275.01 -> pr275.02) on top of the merged bitcoin/bitcoin#21793 -- the dark mode works for every build :)

hebasto · 2021-05-27T11:26:16Z

@promag @jarolrod @Sjors

Do you mind having a (final) look at this PR after the recent rebasing?

Sjors · 2021-05-27T12:07:11Z

This PR does not enable the dark mode for builds that have this feature unavailable now, i.e., native builds with depends.

Is this still true after the latest dependency bumps?

hebasto · 2021-05-27T12:09:32Z

@Sjors

This PR does not enable the dark mode for builds that have this feature unavailable now, i.e., native builds with depends.

Is this still true after the latest dependency bumps?

Good catch! Removed.

Sjors · 2021-05-27T16:52:11Z

tACK c231254 on macOS 11.4

The code changes look sane, but I didn't study them in detail.

This should also be tested on Linux and Windows, since not everything is wrapped in #ifdef Q_OS_MACOS.

I tested with and without depends. I'm able to toggle between dark and light mode in various screens and it looks healthy.

goums · 2021-05-27T21:10:04Z

ACK c231254

Tested on mac OS Big Sur (11.2.3)
Light/dark mode switching works very smoothly on every windows 👍
Compare to previous version, all icons and labels are re-colorized accordingly to the theme change

Screen capture for those who are not testing on macOS:

macos-light-dark-mode-switching.mov

jarolrod

tACK c231254

Tested over all possible configurations (as i did here: #275 (review)). Also tested on Linux and Windows to ensure there are no introduced visual glitches. This looks good to merge.

hebasto · 2021-05-28T13:10:41Z

This should also be tested on Linux and Windows, since not everything is wrapped in #ifdef Q_OS_MACOS.

On Linux Mint 20.1 (Qt 5.12.8) with installed qt5ct package I'm able to switch themes for Qt apps during their runtime.
This PR does not add support for such theme switching on Linux though. It ls left for follow ups.

promag · 2021-05-28T14:20:24Z

Tested ACK c231254 on macOS Big Sur arm64.

…macOS

hebasto mentioned this pull request Apr 9, 2021

[PoC] [do not merge]: Support runtime appearance adjustment on macOS #274

Closed

hebasto added the macOS label Apr 9, 2021

hebasto mentioned this pull request Apr 9, 2021

macOS theme switching not supported #268

Closed

jarolrod reviewed Apr 20, 2021

View reviewed changes

jarolrod mentioned this pull request Apr 28, 2021

build: Fix static Darwin builds bitcoin/bitcoin#21782

Closed

promag reviewed Apr 28, 2021

View reviewed changes

Sjors mentioned this pull request Apr 29, 2021

build: use -isysroot over --sysroot on macOS bitcoin/bitcoin#21793

Merged

jarolrod mentioned this pull request Apr 29, 2021

Text not visible for hide button on macOS #301

Open

hebasto added 12 commits May 1, 2021 15:07

qt: Make PlatformStyle aware of runtime palette change

ce17861

This change is a prerequisite to support changeable appearance on macOS.

qt: Make BitcoinGUI aware of runtime palette change

f108382

This change fixes the GUI when changing appearance on macOS.

qt: Make RPCConsole aware of runtime palette change

fa18d28

This change fixes the GUI when changing appearance on macOS.

qt: Make SendCoinsEntry aware of runtime palette change

0dcc3fa

This change fixes the GUI when changing appearance on macOS.

qt: Make SignVerifyMessageDialog aware of runtime palette change

c054720

This change fixes the GUI when changing appearance on macOS.

qt: Add GUIUtil::ThemedLabel class

d99ef32

The ThemedLabel class correctly handles appearance changes on macOS.

qt: Use GUIUtil::ThemedLabel class

ff530a2

This change fixes the GUI when changing appearance on macOS.

qt: Replace base class of ClickableLabel with ThemedLabel

6b2ce65

This change fixes the GUI when changing appearance on macOS.

qt: Make UnitDisplayStatusBarControl aware of runtime palette change

d05f1b2

This change fixes the GUI when changing appearance on macOS.

qt: Make OverviewPage aware of runtime palette change

97a6b5e

This change fixes the GUI when changing appearance on macOS.

qt: Make CoinControlDialog aware of runtime palette change

2b622d4

This change fixes the GUI when changing appearance on macOS.

qt: Make TransactionView aware of runtime palette change

c231254

This change fixes the GUI when changing appearance on macOS.

hebasto force-pushed the 210409-dark branch from 5737301 to c231254 Compare May 1, 2021 12:20

hebasto added this to the 22.0 milestone May 8, 2021

hebasto mentioned this pull request May 27, 2021

qt: Support macOS Dark mode #154

Merged

goums approved these changes May 27, 2021

View reviewed changes

jarolrod reviewed May 27, 2021

View reviewed changes

hebasto merged commit 123b401 into bitcoin-core:master May 28, 2021

hebasto deleted the 210409-dark branch May 28, 2021 15:09

hebasto mentioned this pull request May 28, 2021

Allow prompt icon to be colorized #330

Merged

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 29, 2021

Merge bitcoin-core/gui#275: Support runtime appearance adjustment on …

69d49c8

…macOS

hebasto mentioned this pull request May 29, 2021

refactor: Make BitcoinUnits::Unit a scoped enum #60

Closed

hebasto mentioned this pull request Jun 6, 2021

Paste button in Open URI dialog #319

Merged

gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022

Merge 123b401 into merged_master (Bitcoin PR bitcoin-core/gui#275)

2645f81

bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support runtime appearance adjustment on macOS #275

Support runtime appearance adjustment on macOS #275

hebasto commented Apr 9, 2021 •

edited

Loading

hebasto commented Apr 9, 2021

RandyMcMillan commented Apr 19, 2021 •

edited

Loading

RandyMcMillan commented Apr 19, 2021

hebasto commented Apr 19, 2021

RandyMcMillan commented Apr 19, 2021

jarolrod left a comment

hebasto commented Apr 20, 2021

hebasto commented Apr 20, 2021

promag left a comment

hebasto commented May 1, 2021 •

edited

Loading

hebasto commented May 27, 2021

Sjors commented May 27, 2021

hebasto commented May 27, 2021

Sjors commented May 27, 2021 •

edited

Loading

goums commented May 27, 2021

jarolrod left a comment

hebasto commented May 28, 2021

promag commented May 28, 2021

Support runtime appearance adjustment on macOS #275

Support runtime appearance adjustment on macOS #275

Conversation

hebasto commented Apr 9, 2021 • edited Loading

hebasto commented Apr 9, 2021

RandyMcMillan commented Apr 19, 2021 • edited Loading

MacOS 10.14.6 (18G8022) Light Theme

MacOS 10.14.6 (18G8022) Dark Theme

RandyMcMillan commented Apr 19, 2021

hebasto commented Apr 19, 2021

RandyMcMillan commented Apr 19, 2021

jarolrod left a comment

Choose a reason for hiding this comment

macOS 10.14 Mojave

Native Compile

Native Depends Build

Linux Cross-Compile for macOS

This PR + macOS Toolchain Bump

macOS 10.15 Catalina

Native Compile

Native Depends Build

Linux Cross-Compile for macOS

This PR + macOS Toolchain Bump

macOS 11 Big Sur

Native Compile

Native Depends Build

Linux Cross-Compile for macOS

This PR + macOS Toolchain Bump

hebasto commented Apr 20, 2021

hebasto commented Apr 20, 2021

promag left a comment

Choose a reason for hiding this comment

hebasto commented May 1, 2021 • edited Loading

hebasto commented May 27, 2021

Sjors commented May 27, 2021

hebasto commented May 27, 2021

Sjors commented May 27, 2021 • edited Loading

goums commented May 27, 2021

jarolrod left a comment

Choose a reason for hiding this comment

hebasto commented May 28, 2021

promag commented May 28, 2021

hebasto commented Apr 9, 2021 •

edited

Loading

RandyMcMillan commented Apr 19, 2021 •

edited

Loading

hebasto commented May 1, 2021 •

edited

Loading

Sjors commented May 27, 2021 •

edited

Loading