Make console buttons look clickable

[jarolrod]

On master, for macOS, the console buttons' hitboxes are quite small. This makes clicking on the button with your mouse a little more tedious than it should be. The Issue is related to recent versions of Qt (>5.9.8) not playing so nice on macOS when there are "incorrect" width and height values set for a QPushButton (here is another example: #319 (review)).

This fixes this small hitbox issue by converting the buttons from QPushButton to QToolButton, which in turn makes the buttons look explicitly clickable. This approach was chosen as it helps us avoid having to play around with width and height values until we find values that play nice with macOS and look good on Linux & Windows. Also, QToolButton is an appropriate class for these buttons.

Per Qt Docs:

A tool button is a special button that provides quick-access to specific commands or options. As opposed to a normal command button, a tool button usually doesn't show a text label, but shows an icon instead.

Since we are changing the type of the buttons, we need to change the respective actions connection logic in rpcconsole. Instead of plugging in QToolButton, we abstract it to the base class: QAbstractButton.

per Qt Dev Notes

Use base class functions as this makes the code more general, e.g., use QAbstractButton::clicked instead of QPushButton::clicked.

While here, we also update the size of the icons to 22x22 to be consistent with other tool buttons.

macOS: Master vs PR:

Master	PR

Linux: Master vs PR:

Master	PR

[hebasto]

Concept ACK on making clickable elements explicit (see #217).

On master, for macOS, the console buttons' hitboxes are quite small

How do your changes increase their sizes?

[jarolrod]

@hebasto

How do your changes increase their sizes?

It seems a better name for this PR would be "Make Console Buttons Look Clickable" as that is what it really does for all systems. The PR was motivated by the small hitbox bug on macOS, this is fixed by making the buttons a QToolButton instead of finding appropriate width and height values for aQPushButton.

[jarolrod]

updated from 05808da -> 8b419b5:

Changes:

• Change naming of commit and pr to better represent what the PR is doing

[hebasto]

ACK 8b419b5, tested on Linux Mint 20.1 (Qt 5.12.8).

[promag]

Not a NACK, personally I think they are fine as is.

[promag]

Tested ACK 8b419b5 on macOS Big Sur M1, this drops only relevant usages to flat buttons.

nit, could drop the following:

gui/src/qt/forms/psbtoperationsdialog.ui

Lines 94 to 96 in aedf71d

	<property name="flat">
	<bool>false</bool>
	</property>

[promag]

Played around and with

          </item>
          <item>
           <widget class="QPushButton" name="fontSmallerButton">
-           <property name="maximumSize">
-            <size>
-             <width>24</width>
-             <height>24</height>
-            </size>
-           </property>
            <property name="toolTip">
             <string>Decrease font size</string>
            </property>
@@ -490,7 +484,7 @@
            <property name="iconSize">
             <size>
              <width>24</width>
-             <height>16</height>
+             <height>24</height>
             </size>
            </property>
            <property name="autoDefault">

I get this

and when clicking

So it seems that maximumSize is screwing the button layout.