Add ability to integrate the client with desktop environment on Linux

[hebasto]

On Linux a new menu item "Settings" --> "Integrate with desktop environment" is available now (non-regtest only).

Here are some screenshots:

Closes #31

---

Localization of the *.desktop files is out of this PR scope.

[jonatack]

Concept ACK

[hebasto]

Updated 2bd1394 -> 5dc09b5 (pr38.01 -> pr38.02, diff):

• improved user-faced "Comment" field
• screenshot in the OP has been updated

[luke-jr]

Approach NACK. Just restore the .desktop file removed in fa0e1e2 and add the missing bits to configure.ac. There's no reason to go through the application to generate this...

[caiofaustino]

Tested, works well for me.
File created at ~/.local/share/applications/org.bitcoincore.BitcoinQt.desktop

[caiofaustino]

Approach NACK. Just restore the .desktop file removed in fa0e1e2 and add the missing bits to configure.ac. There's no reason to go through the application to generate this...

Can you explain what behaviour that approach would have for a user downloading the binary from the website?
I'm new to most of this, my understanding was that configure.ac. only affected compilation.

[luke-jr]

Can you explain what behaviour that approach would have for a user downloading the binary from the website?

There'd presumably be a .desktop file in the tarball they could install to the right place.

[caiofaustino]

There'd presumably be a .desktop file in the tarball they could install to the right place.

Thanks for the explanation, yeah that could be an alternative, although I think this one is more user friendly, I'm not sure what level of technical expertise is expected from the users.

[hebasto]

Approach NACK. Just restore the .desktop file removed in fa0e1e2 and add the missing bits to configure.ac. There's no reason to go through the application to generate this...

Can you explain what behaviour that approach would have for a user downloading the binary from the website?

There'd presumably be a .desktop file in the tarball they could install to the right place.

Placing a *.desktop file into the tarball requires placing icon files into it as well.

Manually installing a *.desktop and icon files seems not user-friendly.

As a *.desktop and icon files usually are parts of packages (e.g., https://snapcraft.io/bitcoin-core, https://packages.debian.org/sid/main/bitcoin-qt), it is possible that a configure option is required to disable this feature for package maintainers.
@MarcoFalke What do you think about it?

[luke-jr]

Packagers would simply switch to the bundled icon/desktop files...

[hebasto]

Packagers would simply switch to the bundled icon/desktop files...

Yes, that is what I mean: if icon/desktop files are bundled into the package there is no need to compile the feature introduced in this PR; therefore it could be disabled by the configure script.

[hebasto]

Approach NACK. Just restore the .desktop file removed in fa0e1e2 and add the missing bits to configure.ac. There's no reason to go through the application to generate this...

The alternative approach is bitcoin/bitcoin#15068

[hebasto]

Rebased 5dc09b5 -> 95c0cff (pr38.02 -> pr38.03) due to the conflict with bitcoin/bitcoin#15704.

[jarolrod]

Tested ACK on Arch Linux and KDE Plasma. Works smoothly.
Also tested to make sure this option doesn't show up on macOS.

One question: the option does not show up when testing on FreeBSD, how do we add support for the BSD's?

[hebasto]

@jarolrod

Tested ACK on Arch Linux and KDE Plasma. Works smoothly.
Also tested to make sure this option doesn't show up on macOS.

Thank you for testing.

One question: the option does not show up when testing on FreeBSD, how do we add support for the BSD's?

I'm not familiar with BSD world, except of macOS :)

[DrahtBot]

🐙 This pull request conflicts with the target branch and needs rebase.

_{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}

[hebasto]

Closing and leaving it up for grabs.

[caiofaustino]

What does leaving for grabs mean? Is this feature still considered or does it need further discussion?

[hebasto]

What does leaving for grabs mean? Is this feature still considered or does it need further discussion?

Anyone could continue this work. Although, a new pr will be a subject for discussion.