Improvements to the open up transaction in third-party link action

[jarolrod]

#4092 introduced the ability to open up a transaction in a block explorer. This improves the related code by simplifying the addition and connection of the action through an overloaded addAction function and prepends action description text to the host, "Show in". The reason to add this text is to make it clear what the action does. It also creates a clearer mental correlation between a user doing the work to add the 3rd-party tx link and this new menu action popping up.

This updates the setting text so that "third-party" is hyphenated. It should be hyphenated because it is being used as a modifier of both "URL" and "transaction URLs".

Additionally, this fixes #431 by ensuring that the seperator will be added before creating action.

Screenshots of visual changes:

Context menu actions

master	pr

Setting text
(tooltip text containing usage of "third-party" is also properly hyphenated)

master	pr

[jarolrod]

Updated from a70a980 -> 8177578 (pr430.01 -> pr430.02, diff)

Changes: include new commit to fix #431

[shaavan]

Concept ACK

This PR introduced the overloaded addAction function, which simplifies the code while keeping the functionality intact. The introduced translator’s comments also look good. I have a suggestion regarding them that I will come to in a minute. Finally, the added actions_created boolean allows solving the bug of separator not being added while also increasing the understandability of the code without additional comments.

[jarolrod]

Updated from 8177578 -> 2ccde2f (pr430.02 -> pr430.03, diff)

Changes: included one more commit to address the proper hyphenation of "third-party".

[shaavan]

The new commit looks good. I have tested the PR on Ubuntu 20.04 (using Qt version 5.12.8) with the recent commit, and the changes are reflected perfectly in the GUI.

Master	PR

[stratospher]

tested ACK 2ccde2f.
In agreement with the PR's objectives. The PR was tested and verified to be consistent with the proposed changes:

1. Adding the description "Show in" - gave a clearer idea of the menu action.
2. Hyphenating to “third-party”
3. Fixing #431 so that the separator between third-party link actions and normal actions are in different sections even when the first string in a Third party transaction URL is empty. ( Example from #431 : | | https://mempool.space/tx/%s | https://blockstream.info/tx/%s)

Notes:

• 9980f4a
  addAction() adds openThirdPartyTxUrl() to the menu's list of actions and returns it directly. This simplifies the code as compared to the previous version where connect() was used.
• a70a980
  Adds the description "Show in" to get a clear picture that we want to show the transaction in a third party transaction URL.
• 8177578
  Makes a separate section for third-party links
  Uses a boolean variable to identify the first non-empty string and then adds the separator instead of arbitrarily adding the separator after the first string in listUrls[].
• 2ccde2f
  Makes “Third party” -> “Third-party”

[promag]

Code view ACK 2ccde2f.

[hebasto]

Tested 2ccde2f on Linux Mint 20.2 (Qt 5.12.8) -- #431 is fixed.

An idea for a follow up -- introduce a warning message about possibility to break privacy while using external links.

@prayank23 What do you think about such a warning?

[hebasto]

ACK 2ccde2f

[ghost]

An idea for a follow up -- introduce a warning message about possibility to break privacy while using external links.

Yes we can inform the user about privacy issues because using such block explorers when you are running your own node doesn't make sense. Can add one line about using open source explorers with Bitcoin Core so URL will be localhost.

[promag]

The user might want to share the link with someone?

[ghost]

The user might want to share the link with someone?

Makes sense. Warning can be avoided in that case or sharing transaction id without explorer links is also good enough as the other person can check it in the explorer they prefer to use.

I was testing different things in GUI today to see if attackers can get IP for users and a fun experiment to share problems with users can be:

1. Create a DNS token: https://canarytokens.org/generate
2. Save https://randomchars.canarytokens.com/tx/%s in Bitcoin Core settings
3. Right click on any transaction
4. Check your email for IP address

Why would someone use a random explorer? Attackers can use several ways to convince newbies with features that are not available in other explorers. Example: https://bitcointalk.org/index.php?topic=2100392.0