Restore "S" accelerator for "Start on system login" option #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shift RPC server option to use "P" instead
shaavan
reviewed
Oct 8, 2021
There was a problem hiding this comment.
No strong opinion for now
The purpose of the mnemonic shortcut is to increase the speed of workflow. For that, they need to be such that they are easily recognizable and easy to remember.
So for the RPC server setting, the most natural shortcut would be the letter R. But since that is already taken, we must use another letter. According to me, the second-best choice is to use the first letter of the second word (i.e., s) instead of the second letter of the first word (i.e., P).
The reason why I think so is:
- The corresponding command line setting for this option is -server, which makes the shortcut s quickly form an association in our mind with this setting, making the shortcut easy to remember.
- The second reason being how our brain remembers and correlates things. I am not proficient in its science, but as far as I know, our brain tends to associate a word with its first letter rather than the latter. This is very similar to how we can just quickly recall a complete song in our head if someone tells the few starting words and rhythm of the song, whereas we struggle to recall if someone starts the music from the middle.
From this perspective, the shortcut P does not have an as strong association with the word RPC in our mind as the shortcut s has with the word server.
These were just my two cents. I might be wrong in some of my reasoning. In that case, please correct me. But for now, I think the shortcuts are good as they currently are.
|
Using R as a shortcut for RPC clashed according to @hebasto: #416 (comment) Using P instead is fine by me. |
hebasto
changed the title
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 22, 2021
…tem login" option 25a5814 GUI/Options: Restore "S" accelerator for "Start on system login" option (Luke Dashjr) Pull request description: bitcoin-core/gui#416 changed the option assigned to accelerator key "S", but there's no rationale given. Best to leave it alone, and give the new option a new accelerator key. Since "R" is already taken for Reset, this shifts the new RPC server option to use "P" instead ACKs for top commit: jarolrod: ACK 25a5814 hebasto: ACK 25a5814, tested on Linux Mint 20.2 (Qt 5.12.8). Tree-SHA512: 2212aa32572cbcbcce78304ffcb1dcfc65f9d7e2ffd6c6a4b65e4a3ca2a8a7cc7505c28314ad46e0bc13b4e3bb3fc61e7e196356d26354f3689fad71fb688b27
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 23, 2021
…tem login" option 25a5814 GUI/Options: Restore "S" accelerator for "Start on system login" option (Luke Dashjr) Pull request description: bitcoin-core/gui#416 changed the option assigned to accelerator key "S", but there's no rationale given. Best to leave it alone, and give the new option a new accelerator key. Since "R" is already taken for Reset, this shifts the new RPC server option to use "P" instead ACKs for top commit: jarolrod: ACK 25a5814 hebasto: ACK 25a5814, tested on Linux Mint 20.2 (Qt 5.12.8). Tree-SHA512: 2212aa32572cbcbcce78304ffcb1dcfc65f9d7e2ffd6c6a4b65e4a3ca2a8a7cc7505c28314ad46e0bc13b4e3bb3fc61e7e196356d26354f3689fad71fb688b27
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#416 changed the option assigned to accelerator key "S", but there's no rationale given.
Best to leave it alone, and give the new option a new accelerator key.
Since "R" is already taken for Reset, this shifts the new RPC server option to use "P" instead