refactor, qt: Use std::chrono for parameters of QTimer methods

[hebasto]

Since Qt 5.8 QTimer methods have overloads that accept std::chrono::milliseconds arguments:

• QTimer::singleShot
• QTimer::start

[hebasto]

cc @shaavan @promag @jarolrod

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #497 (Enable users to configure their monospace font specifically by luke-jr)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[promag]

Code review ACK 1009baf.

[shaavan]

Code Review ACK 1009baf

• I prefer using std::chrono over int64_t for time variables wherever possible. So I agree with the PR's concept.
• Also, the refactor looks clean, and makes code more readable.

I have added some suggestions that might help make this PR even better.

p.s. While reviewing this PR, I came across two functions in the codebase GetTime and GetSystemTime. So I was curious whether these have different functionalities or are similar in their use case.

[jarolrod]

ACK 1009baf

Code Review and tested ACK. I've verified that all instances of ConfirmMessage have been updated.

in 94f914b, since the commit message states Use std::chrono in parameters of QTimer methods you could update all instances to use the std::chrono overload, even the 0 ones. Otherwise, this commit is reallly just Use std::chrono in parameters of QTimer methods time is > 0

[hebasto]

Updated 1009baf -> f3bdc14 (pr517.01 -> pr517.02):

• rebased due to the conflict with Add Create Unsigned button to SendConfirmationDialog #441
• addressed @shaavan's comment
• addressed @jarolrod's comment

@jarolrod

you could update all instances to use the std::chrono overload, even the 0 ones.

Don't want to choose units for arguments :)

[jarolrod]

re-ACK f3bdc14

[promag]

Code review ACK f3bdc14.

But there are other cases like

gui/src/qt/trafficgraphwidget.cpp

Line 161 in 1f7acfd

timer->setInterval(msecsPerSample);

gui/src/qt/transactionview.cpp

Line 118 in 1f7acfd

static const int input_filter_delay = 200;

gui/src/qt/transactionview.cpp

Line 126 in 1f7acfd

prefix_typing_delay->setInterval(input_filter_delay);

[hebasto]

Thanks @promag

But there are other cases like
https://github.com/bitcoin/bitcoin/blob/1f7acfdcca3525edf3eba23535240d23ff0c4fc9/src/qt/trafficgraphwidget.cpp#L161
https://github.com/bitcoin/bitcoin/blob/1f7acfdcca3525edf3eba23535240d23ff0c4fc9/src/qt/transactionview.cpp#L118
https://github.com/bitcoin/bitcoin/blob/1f7acfdcca3525edf3eba23535240d23ff0c4fc9/src/qt/transactionview.cpp#L126

Added a commit which addresses the case in TransactionView::TransactionView.

Refactoring of TrafficGraphWidget I leaved for an follow up, as it looks non-trivial.

[promag]

Code review ACK 51250b0.

[shaavan]

reACK 51250b0

Changes since my last review:

• MODEL_UPDATE_DELAY.count() -> count_milliseconds(MODEL_UPDATE_DELAY)
• Consequently #include <chrono> -> #include <util/time.h> in src/qt/clientmodel.h
• Variable input_filter_delay has been converted from int to std::chrono.

The update takes care of the input_filter_delay. And as for the TrafficGraphWidget variable, let me try giving it a shot.