Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test, refactor: Use the same shutdown path as in bitcoin-qt binary #611

Closed
wants to merge 1 commit into from

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented May 30, 2022

Since #336, the bitcoin-qt shutdown process has been streamlined, and initiating of another event loop is no longer required.

This PR applies the same approach for tests.

@hebasto hebasto added the Tests label May 30, 2022
@hebasto hebasto marked this pull request as draft May 30, 2022 13:14
Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review ACK 1ac9149

Actually, broken, will investigate

@bitcoin-core bitcoin-core deleted a comment from Mireyavs Jun 29, 2022
@bitcoin-core bitcoin-core deleted a comment from DrahtBot Nov 7, 2022
@hebasto hebasto closed this Mar 27, 2023
@bitcoin-core bitcoin-core locked and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants