Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy: Force checks for headers in src/qt #686

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Dec 16, 2022

This PR split from bitcoin/bitcoin#26705 and contains only changes in src/qt.

Effectively, it fixes the clang-tidy's modernize-use-default-member-init errors, and forces clang-tidy checks for all headers in the src/qt directory.

@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 16, 2022

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK jarolrod

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #684 (Improve 'Requested Payments History' Multiselect by john-moffett)
  • #662 (Fix transaction view/table by luke-jr)
  • #658 (Intro: Never change the prune checkbox after the user has touched it by luke-jr)
  • #537 (Point out position of invalid characters in Bech32 addresses by luke-jr)
  • #497 (Enable users to configure their monospace font specifically by luke-jr)
  • #152 (Initialise DBus notifications in another thread by luke-jr)
  • #bitcoin/bitcoin/26858 (wallet: Use defined purposes instead of inlining by aureleoules)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@hebasto
Copy link
Member Author

hebasto commented Dec 20, 2022

Friendly ping @jarolrod :)

@hebasto hebasto changed the title clang-tidy, qt: Force checks for headers in src/qt clang-tidy: Force checks for headers in src/qt Dec 20, 2022
Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7b7cd11

To confirm the correctness of the changes, I dropped the first commit and ran the CI locally. The log for the tidy task states what to fix, I went through this, painstakingly, for a long time, and arrived to the same diff as this PR.

Also did some light testing of the binary with these changes. Also, CI is happy.

@hebasto hebasto merged commit b7f6a89 into bitcoin-core:master Jan 17, 2023
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 17, 2023
@bitcoin-core bitcoin-core locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants