-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clang-tidy: Force checks for headers in src/qt
#686
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Friendly ping @jarolrod :) |
src/qt
src/qt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 7b7cd11
To confirm the correctness of the changes, I dropped the first commit and ran the CI locally. The log for the tidy task states what to fix, I went through this, painstakingly, for a long time, and arrived to the same diff as this PR.
Also did some light testing of the binary with these changes. Also, CI is happy.
This PR split from bitcoin/bitcoin#26705 and contains only changes in
src/qt
.Effectively, it fixes the clang-tidy's
modernize-use-default-member-init
errors, and forces clang-tidy checks for all headers in thesrc/qt
directory.