Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog for allowing the user to choose the change output when bumping a tx #700

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Dialog for allowing the user to choose the change output when bumping a tx #700

wants to merge 3 commits into from
+285 −6

Commits on Jan 8, 2024

  1. interfaces: Expose CreateRateBumpTransaction's orig_change_pos

    @achow101
    achow101 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    e1ea0ba View commit details
    Browse the repository at this point in the history

  2. interfaces: Add isChange to wallet interface

    @achow101
    achow101 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    eacdc14 View commit details
    Browse the repository at this point in the history

  3. qt: Add a dialog to select the change output when bumping fee 

    In order to correctly choose the change output when doing fee bumping in
the GUI, we need to ask the user which output is change. We can make a
guess using our ScriptIsChange heuristic, however the user may have
chosen to have a custom change address or have otherwise labeled their
change address which makes our change detection fail. By asking the user
when fee bumping, we can avoid adding additional change outputs that are
unnecessary.
    @achow101
    achow101 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    c697167 View commit details
    Browse the repository at this point in the history