Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warnings for non-active addresses in receive tab and address book #723

Closed
wants to merge 8 commits into from
Closed

Add warnings for non-active addresses in receive tab and address book #723

wants to merge 8 commits into from

Commits on May 1, 2023

  1. wallet: implement IsKeyActive() in scriptpubkeyman 

    This new method returns true if the given CScript key is derived
from the SPKM. For Legacy that means checking the hd_seed_id in the
key's metadata.

Also patches PKDescriptor to return associated public keys in
MakeScripts()
    @pinheadmz
    pinheadmz committed May 1, 2023
    Configuration menu
    Copy the full SHA
    ea1f304 View commit details
    Browse the repository at this point in the history

  2. wallet: implement IsDestinationActive() and add to rpc getaddressinfo 

    This connects SPKM.IsKeyActive() up to the wallet level.
    @pinheadmz
    pinheadmz committed May 1, 2023
    Configuration menu
    Copy the full SHA
    abad1e0 View commit details
    Browse the repository at this point in the history

  3. test: cover ScriptPubKeyMan::IsKeyActive()

    @pinheadmz
    pinheadmz committed May 1, 2023
    Configuration menu
    Copy the full SHA
    c6d2565 View commit details
    Browse the repository at this point in the history

  4. test: cover "isactive" field in rpc getaddressinfo

    @pinheadmz
    pinheadmz committed May 1, 2023
    Configuration menu
    Copy the full SHA
    1b2e020 View commit details
    Browse the repository at this point in the history

  5. doc: release notes for #27216

    @pinheadmz
    pinheadmz committed May 1, 2023
    Configuration menu
    Copy the full SHA
    712e366 View commit details
    Browse the repository at this point in the history

  6. qt: add warnings to receive request table and dialog 

    Tool tip and dialog field can be expanded in the future.
For now the first warning we show is if the address was
derived from a non-active seed or descriptor.
See bitcoin/bitcoin#3314
    @pinheadmz
    pinheadmz committed May 1, 2023
    Configuration menu
    Copy the full SHA
    979f8c2 View commit details
    Browse the repository at this point in the history

  7. qt: add warning labels in address book receive tab 

    Tool tip can be expanded in the future.
For now the first warning we show is if the address was
derived from a non-active seed or descriptor.
See bitcoin/bitcoin#3314
    @pinheadmz
    pinheadmz committed May 1, 2023
    Configuration menu
    Copy the full SHA
    fc6cc2a View commit details
    Browse the repository at this point in the history

  8. qt: update address warnings when wallet is encrypted

    @pinheadmz
    pinheadmz committed May 1, 2023
    Configuration menu
    Copy the full SHA
    d6519a8 View commit details
    Browse the repository at this point in the history