Show own outputs on PSBT signing window #740
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
Concept ACK Tested on regtest. Works as described and it does indeed fix #732. |
There was a problem hiding this comment.
Tested ACK on signet, both, @kallerosenbaum's use case (where you have a watch-only wallet "online" and you sign the tx "offline", then you will need to broadcast it ofc) and a multisig wallet case mentioned by @hernanmarino in the description of this PR, work as expected.
Perhaps it would be more noticeable if the colour of the added text "(own address)" is changed?
Also, I couldn't find any test using txoutIsMine(), although there are for IsMine().
edit: forgot to mention, for the multisig wallet use case, one should create it with the own private key and the public key/ s from the other signers, so when we select it and check the PBST it will be shown the "own address" text in the tx window.
|
ACK 4da243b |
4da243b qt: show own outputs on PSBT signing window (Hernan Marino) Pull request description: This fixes bitcoin-core/gui#732 . It allows you to identify your own addresses in the outputs of a transaction in the PSBT signing window. This enables easy identification of change outputs, and prevents certain attacks where someone (co-signers of a multisig, or others ) might trick you into signing a transaction while they are stealing the change, since prior to this modification there was no easy way of knowing this. The identification of the output is similar to the way this is done in the transaction details window. A sample output is :  ACKs for top commit: achow101: ACK 4da243b jarolrod: ACK 4da243b Tree-SHA512: fa9901d2acc84472c11afcd0a59a859db598cdf5cea755b492178d3e7434b70d9bd8f554928938a2ff9920c8f397fef814ce14b416556c30fba0c3c1f62cd722
This fixes #732 .
It allows you to identify your own addresses in the outputs of a transaction in the PSBT signing window. This enables easy identification of change outputs, and prevents certain attacks where someone (co-signers of a multisig, or others ) might trick you into signing a transaction while they are stealing the change, since prior to this modification there was no easy way of knowing this.
The identification of the output is similar to the way this is done in the transaction details window.
A sample output is :