-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open fully encrypted wallets #747
Closed
achow101
wants to merge
15
commits into
bitcoin-core:master
from
achow101:gui-fully-encrypted-wallets
Closed
Open fully encrypted wallets #747
achow101
wants to merge
15
commits into
bitcoin-core:master
from
achow101:gui-fully-encrypted-wallets
Commits on Jul 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a783e5c - Browse repository at this point
Copy the full SHA a783e5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c3d81f - Browse repository at this point
Copy the full SHA 2c3d81fView commit details -
walletdb: Add EncryptedDatabase and its batch and cursor classes
EncryptedDatabase is a WalletDatabase that encrypts the records before writing them to an underlying WalletDatabase. This encryption occurs transparently to the higher level application logic so the wallet does not need to be concerned about whether the data it is writing is encrypted. In order to work with prefix matching and cursor iteration in an order that we are expecting, EncryptedDatabase maintains a map of the unencrypted record keys to the encrypted record keys. When given the plaintext record key to pull up, it can retrieve the encrypted record key and then retrieve the encrypted record from the underlying database.
Configuration menu - View commit details
-
Copy full SHA for a203061 - Browse repository at this point
Copy the full SHA a203061View commit details -
walletdb: Add WalletBatch::Read overload for DataStream
It's useful to be able to just read a record without the batch doing any sort of deserialization. The new overload of Read will just place the record's value into the provided DataStream.
Configuration menu - View commit details
-
Copy full SHA for 037e6f0 - Browse repository at this point
Copy the full SHA 037e6f0View commit details -
walletdb: Use a different SQLite application id for encrypted db
EncrytpedDB wallets will use sqlite but with a different application id. This provides downgrade protection in addition to easy identification of encrypted dbs. The application id will be the network magic XOR'd with 0x36932d47 (randomly generated value).
Configuration menu - View commit details
-
Copy full SHA for 29cbbbc - Browse repository at this point
Copy the full SHA 29cbbbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2568277 - Browse repository at this point
Copy the full SHA 2568277View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c7df1f - Browse repository at this point
Copy the full SHA 4c7df1fView commit details -
wallet: Skip loading on start of wallets with encrypted databases
Wallets with encrypted databases need the user to provide their database passphrase which cannot be done on start, so skip any such wallets on startup.
Configuration menu - View commit details
-
Copy full SHA for 0a38dc8 - Browse repository at this point
Copy the full SHA 0a38dc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d97c315 - Browse repository at this point
Copy the full SHA d97c315View commit details -
gui: Allow AskPassphraseDialog without WalletModel
Sometimes we just need the dialog without an attached wallet.
Configuration menu - View commit details
-
Copy full SHA for 854ab2e - Browse repository at this point
Copy the full SHA 854ab2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a85e428 - Browse repository at this point
Copy the full SHA a85e428View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6212f9 - Browse repository at this point
Copy the full SHA a6212f9View commit details -
gui: Allow AskPassphraseDialog to have customized warning text
The warning text that appears above the passphrase inputs may need to be customized depending on the context in which the passphrase is being entered, so let the caller optionally set it.
Configuration menu - View commit details
-
Copy full SHA for 5506eea - Browse repository at this point
Copy the full SHA 5506eeaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 33cceb9 - Browse repository at this point
Copy the full SHA 33cceb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93fe316 - Browse repository at this point
Copy the full SHA 93fe316View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.