debugwindow: update session ID tooltip

[MarnixCroes]

When you have a v2 connection, there is always a session ID.

the if any is a leftover from #754, where the session ID property initially would always be displayed (transport v1 and v2).
So the session ID could be empty when you have a v1 connection.

As now the Session ID property only is displayed for v2 connection, there will always be a session ID.

master

PR

Session ID not shown when transport v1

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	kristapsk, vostrnad, jarolrod, pablomartin4btc, hebasto
Concept ACK	BrandonOdiwuor, hernanmarino

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

[pablomartin4btc]

Concept ACK

nit: @MarnixCroes, maybe you can add the screenshot for transport v1 and session ID is empty/ not shown, if possible, even this PR doesn't affect that logic.

[MarnixCroes]

Concept ACK

nit: @MarnixCroes, maybe you can add the screenshot for transport v1 and session ID is empty/ not shown, if possible, even this PR doesn't affect that logic.

done

[kristapsk]

ACK 3bf00e1

[BrandonOdiwuor]

Concept ACK

[vostrnad]

ACK 3bf00e1

[hernanmarino]

Concept ACK

[jarolrod]

ACK 3bf00e1

[hebasto]

When you have a v2 connection, there is always a session ID.

What if the connection type is still DETECTING?

The code reference:

gui/src/node/connection_types.h

Lines 83 to 88 in 6737331

	/** Transport layer version */
	enum class TransportProtocolType : uint8_t {
	DETECTING, //!< Peer could be v1 or v2
	V1, //!< Unencrypted, plaintext protocol
	V2, //!< BIP324 protocol
	};

[MarnixCroes]

When you have a v2 connection, there is always a session ID.

What if the connection type is still DETECTING?

The code reference:

gui/src/node/connection_types.h

Lines 83 to 88 in 6737331

	/** Transport layer version */
	enum class TransportProtocolType : uint8_t {
	DETECTING, //!< Peer could be v1 or v2
	V1, //!< Unencrypted, plaintext protocol
	V2, //!< BIP324 protocol
	};

then there is no session ID property
as it is not a v2 peer (yet), right

[pablomartin4btc]

tACK 3bf00e1

Tested on Ubuntu 22.04 using signet (./src/qt/bitcoin-qt -signet) otherwise I couldn't find v2 peers on testnet.

• v2 transport with Session ID field displayed:

• v1 transport without it:

@hebasto this PR only updates peerSessionIdLabel tooltip; this widget and the "Session ID" one, right below on the ui form, won't be shown on "DETECTING" TransportProtocolType enum:

gui/src/qt/rpcconsole.cpp

Lines 1208 to 1215 in d04324a

	if (stats->nodeStats.m_transport_type == TransportProtocolType::V2) {
	ui->peerSessionIdLabel->setVisible(true);
	ui->peerSessionId->setVisible(true);
	ui->peerSessionId->setText(QString::fromStdString(stats->nodeStats.m_session_id));
	} else {
	ui->peerSessionIdLabel->setVisible(false);
	ui->peerSessionId->setVisible(false);
	}

[pablomartin4btc]

nit: you could expand a bit on the details of the reason of the removal of "if any" from the label in the commit body (i.e. as it's only shown in v2 transport which will always have a session id).

[hebasto]

ACK 3bf00e1.

[gatleas17]

Help!