Skip to content

Fix -Wsign-compare compiler warning #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hebasto wants to merge 1 commit into from
Closed

Fix -Wsign-compare compiler warning #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mp/gen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,7 @@ int main(int argc, char** argv)
} else {
throw std::runtime_error(std::string("Failed to open src_prefix prefix directory: ") + argv[1]);
}
for (size_t i = 4; i < argc; ++i) {
for (size_t i = 4; i < static_cast<size_t>(argc); ++i) {
KJ_IF_MAYBE(dir, fs->getRoot().tryOpenSubdir(cwd.evalNative(argv[i]))) {
Comment on lines +633 to 634
Copy link
Collaborator

@ryanofsky ryanofsky Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In commit "Fix -Wsign-compare compiler warning" (7452ddd)

Is switching size_t on this line to int enough to fix the problem? It would seem better to avoid this error by using the same type consistently and avoiding the need to cast.

Copy link
Collaborator

@ryanofsky ryanofsky Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re: #151 (comment)

Went ahead and made this change in #152 but did not confirm it fixes the warning (since I wasn't seeing the warning). If not, can use the fix here instead.

Copy link
Member Author

@hebasto hebasto Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the commit from #152 fixed the warning.

import_paths.emplace_back(argv[i]);
import_dirs.emplace_back(kj::mv(*dir));
Expand Down