Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete nonreduced inputs #119

Merged
merged 3 commits into from
Apr 29, 2023
Merged

Delete nonreduced inputs #119

merged 3 commits into from
Apr 29, 2023

Conversation

maflcko
Copy link
Contributor

@maflcko maflcko commented Apr 21, 2023

As per the usual process to avoid wasted CI resources and timeouts when it runs on large and presumed irrelevant inputs.

Previous: #97

@maflcko
Copy link
Contributor Author

maflcko commented Apr 21, 2023

To "reproduce"

Install a fresh VM, as explained in the bash script's doc, and run it:

apt update && apt install wget -y
wget https://raw.githubusercontent.com/bitcoin-core/bitcoin-maintainer-tools/main/delete_nonreduced_fuzz_inputs.sh
bash delete_nonreduced_fuzz_inputs.sh

To "test"

  • Keep an eye on coverage stats, to ensure it doesn't drop
  • Re-run the script, to ensure it is "reproducible" to some extent
  • Anything else you think is important to test or review

@maflcko
Copy link
Contributor Author

maflcko commented Apr 21, 2023

Did a second run. Some stats:

  • 100k deleted in the first run (this pull):
git diff --stat origin/main..659929450b0a5a77739e0f5cde54808de6ca0b64 | tail -1 
 98710 files changed, 1133401 deletions(-)
  • ~Same in the second run:
git diff --stat origin/main..HEAD | tail -1 
 98459 files changed, 83802 deletions(-)
  • Cross-diff 31k files:
# git diff --stat 659929450b0a5a77739e0f5cde54808de6ca0b64..HEAD | tail -1 
 31968 files changed, 1053259 insertions(+), 3664 deletions(-)

@maflcko
Copy link
Contributor Author

maflcko commented Apr 28, 2023

cc @fanquake @dergoegge

@fanquake fanquake merged commit 46de679 into bitcoin-core:main Apr 29, 2023
@maflcko maflcko mentioned this pull request Oct 23, 2023
fanquake added a commit that referenced this pull request Oct 25, 2023
428a2e7 Remove large utxo_total_supply fuzz inputs for now (MarcoFalke)
01a9287 Reduced inputs for fuzzer,address,undefined,integer (delete_nonreduced_inputs script)
a45c724 Reduced inputs for fuzzer (delete_nonreduced_inputs script)
4b8b07d Delete fuzz inputs (delete_nonreduced_inputs script)

Pull request description:

  As per the usual process to avoid wasted CI resources and timeouts when it runs on large and presumed irrelevant inputs.

  Previous: #119

  ### To "reproduce"

  Install a fresh VM, as explained in the bash script's doc, and run it:

  ```
  apt update && apt install wget -y
  wget https://raw.githubusercontent.com/bitcoin-core/bitcoin-maintainer-tools/main/delete_nonreduced_fuzz_inputs.sh
  bash delete_nonreduced_fuzz_inputs.sh
  ```

  ### To "test"

  * Keep an eye on coverage stats, to ensure it doesn't drop
  * Re-run the script, to ensure it is "reproducible" to some extent
  * Anything else you think is important to test or review

ACKs for top commit:
  dergoegge:
    ACK 428a2e7

Tree-SHA512: 055270a2df3878205bdc700586852d8621c20411770516161746c9a20bf22e3ae9878a34eaa0c026ef48f372524f13ef8095a74d59211f612fd7a599f42987b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants