Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issue in automatic enabling of JNI build #379

Closed
afk11 opened this issue Mar 2, 2016 · 0 comments · Fixed by #682
Closed

Minor issue in automatic enabling of JNI build #379

afk11 opened this issue Mar 2, 2016 · 0 comments · Fixed by #682

Comments

@afk11
Copy link
Contributor

afk11 commented Mar 2, 2016

I came across this last night and it took a little tracking down. Since introducing #364, the build system will automatically determine whether JNI can be built. If the environment supports it, the java library is built, but without checking if the necessary modules are also being compiled.

My situation was: only build the library with the pubkey recovery module and install it, compile my bindings for another language.. I ran into a configure error that no usable version of libsecp256k1 could be found. I could coax things to compile all the same (run configure first against bd2895f - the commit before JNI) but using my bindings resulted in an error that secp256k1_schnorr wasn't found.

My bindings didn't have this dependency previously, nor did the default install presume that all modules were to be compiled, so something about JNI building/requiring everything seemed to lead to this.

To fix this, I had to disable JNI, or enable every module to satisfy the JNI libraries dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant