Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Improve and document compiler flag checks #1240

Merged
merged 3 commits into from
Apr 27, 2023
Merged

cmake: Improve and document compiler flag checks #1240

merged 3 commits into from
Apr 27, 2023

Commits on Apr 27, 2023

  1. cmake: Use add_compile_options() in try_add_compile_option() 

    This change drops tinkering with the `COMPILE_OPTIONS` directory
property. Also `try_add_compile_option()` can handle a list of flags
now, if they are required to be checked simultaneously.

An explanatory comments have been added as well.
    @hebasto
    hebasto committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    19516ed View commit details
    Browse the repository at this point in the history

  2. cmake, refactor: Rename try_add_compile_option to try_append_cflags 

    Actually, `try_append_cflags()` can handle a list of flags, and the new
name is similar to the one used in `configure.ac`.
    @hebasto
    hebasto committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    6ece150 View commit details
    Browse the repository at this point in the history

  3. cmake, doc: Document compiler flags

    @hebasto
    hebasto committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    a8d059f View commit details
    Browse the repository at this point in the history