Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark more assembly outputs as early clobber #1307

Merged
merged 3 commits into from
May 12, 2023
Merged

Mark more assembly outputs as early clobber #1307

merged 3 commits into from
May 12, 2023

Commits on May 12, 2023

  1. Bugfix: mark outputs as early clobber in scalar x86_64 asm 

    In the existing code, the compiler is allowed to allocate the RSI register
for outputs m0, m1, or m2, which are written to before the input in RSI is
read from. Fix this by marking them as early clobber.

Reported by ehoffman2 in bitcoin-core#766
    @sipa
    sipa committed May 12, 2023
    Configuration menu
    Copy the full SHA
    0c729ba View commit details
    Browse the repository at this point in the history

  2. Mark stack variables as early clobber for technical correctness 

    In the field 5x52 asm for x86_64, stack variables are provided as outputs.
The existing inputs are all forcibly allocated to registers, so cannot
coincide, but mark them as early clobber anyway to make this clearer.
    @sipa
    sipa committed May 12, 2023
    Configuration menu
    Copy the full SHA
    350b4bd View commit details
    Browse the repository at this point in the history

  3. Add release note

    @sipa
    sipa committed May 12, 2023
    Configuration menu
    Copy the full SHA
    8c9ae37 View commit details
    Browse the repository at this point in the history