Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: improve fe_sqr test (issue #1472) #1490

Merged
merged 2 commits into from
Feb 27, 2024
Merged

tests: improve fe_sqr test (issue #1472) #1490

merged 2 commits into from
Feb 27, 2024

Commits on Feb 27, 2024

  1. tests: improve fe_sqr test 

    Currently the `run_sqr` test doesn't do anything with the
result of the `fe_sqr` call. Improve that by checking that
the equation `(x+y)*(x-y) = x^2 - y^2` holds for some random
values y, as suggested in issue bitcoin-core#1471 by real-or-random.
The existing loop for generating the x values is kept as-is.
    @theStack
    theStack committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    11420a7 View commit details
    Browse the repository at this point in the history

  2. doc: clarify input requirements for secp256k1_fe_mul 

    "... neither can be equal to b." could suggest that the values are not
allowed to be identical, but what is meant here is that the mentioned
inputs shouldn't point to the same object.
    @theStack
    theStack committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    2028069 View commit details
    Browse the repository at this point in the history