Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding compressed public key flag to java api #443

Closed
wants to merge 2 commits into from
Closed

Adding compressed public key flag to java api #443

wants to merge 2 commits into from

Conversation

Christewart
Copy link

Implements the ability to generate a compressed public key from the java API.

@Christewart
Copy link
Author

Christewart commented Feb 21, 2017 •
edited
Loading

Could this build failure from buffer sizes being fixed 65 byte constants?

https://github.com/Christewart/secp256k1/blob/4ef814c3cc25dea55389f3fb2c74536abc82d148/src/java/org_bitcoin_NativeSecp256k1.c#L294-L296

@Christewart Christewart mentioned this pull request Mar 22, 2017
Merged
@Christewart
Adding flag to generate compressed public key for java api
c365395 
Fixing a few checkInvariants

Adding compressed flag to tweak_mul and tweak_add

Fixing some nits
@Christewart
Exposing secp256k1 parsepubkey functionality via isValidPubKey method
2375636 
Exposing secp256k1 parse pubkey functionality in the java api

Fixing some nits, refactoring some code

Changing name of method from 'parsePubKey' to 'isValidPubKey'

Removing compressed flag arg from 'isValidPubKey' method
@Christewart
Copy link
Author

I added a little more functionality, there is now a isValildPubKey method that calls the underlying ec_pubkey_parse. I'd also like to eventually remove the guava dependency. I removed the Preconditions.checkArgument code and create our version called checkInvariant().

@Christewart Christewart mentioned this pull request Mar 8, 2018
Closed
@Christewart
Copy link
Author

superseded by #508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Christewart