Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signRecoverable to the JNI interface. #517

Closed
wants to merge 2 commits into from
Closed

Add signRecoverable to the JNI interface. #517

wants to merge 2 commits into from

Conversation

ademuri
Copy link

@ademuri ademuri commented Mar 9, 2018

This returns the recovery id, in addition to the signature.

@ademuri
Copy link
Author

ademuri commented Mar 10, 2018

Looks like this still needs some work. I'm travelling this week, so I'll look at it next week.

@ademuri
Copy link
Author

ademuri commented Mar 20, 2018

This is ready for review now.

@sipa
Copy link
Contributor

sipa commented Mar 25, 2018

@greenaddress Feel like reviewing this?

@real-or-random real-or-random mentioned this pull request Jan 7, 2020
Merged
@real-or-random
Copy link
Contributor

Closing this because we removed the JNI bindings in #682.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ademuri @sipa @real-or-random