Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ec_ arithmetic more consistent and add documentation #701

Merged
merged 10 commits into from
Apr 30, 2020
Merged

Make ec_ arithmetic more consistent and add documentation #701

merged 10 commits into from
Apr 30, 2020

Commits on Mar 30, 2020

  1. Add scalar_set_b32_seckey which does the same as scalar_set_b32 and a… 

    …lso returns whether it's a valid secret key
    @jonasnick
    jonasnick committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    9ab2cbe View commit details
    Browse the repository at this point in the history

  2. Use scalar_set_b32_seckey in ecdsa_sign, pubkey_create and seckey_verify

    @jonasnick
    jonasnick committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    3fec982 View commit details
    Browse the repository at this point in the history

  3. Add test for boundary conditions of scalar_set_b32 with respect to ov… 

    …erflows
    @jonasnick
    jonasnick committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    8f814cd View commit details
    Browse the repository at this point in the history

  4. Return 0 if the given seckey is invalid in privkey_negate, privkey_tw… 

    …eak_add and privkey_tweak_mul
    @jonasnick
    jonasnick committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    5894e1f View commit details
    Browse the repository at this point in the history

  5. Define valid ECDSA keys in the documentation of seckey_verify

    @jonasnick
    jonasnick committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    f03df0e View commit details
    Browse the repository at this point in the history

  6. Mention that value is unspecified for In/Out parameters if the functi… 

    …on returns 0
    @jonasnick
    jonasnick committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    5a73f14 View commit details
    Browse the repository at this point in the history

  7. Rename private key to secret key in public API (with the exception of… 

    … function names)
    @jonasnick
    jonasnick committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    22911ee View commit details
    Browse the repository at this point in the history

  8. Make ec_privkey functions aliases for ec_seckey_negate, ec_seckey_twe… 

    …ak_add and ec_seckey_mul
    @jonasnick
    jonasnick committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    41fc785 View commit details
    Browse the repository at this point in the history

  9. Make tweak function documentation more consistent. 

    Do this by adding a newline after the first sentence and aligning the rest.
    @jonasnick
    jonasnick committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    89853a0 View commit details
    Browse the repository at this point in the history

  10. Clarify documentation of tweak functions. 

    In particular, mention that the functions return 0 if seckey or tweak are
invalid (as opposed to saying "should" or "must" be valid).
    @jonasnick
    jonasnick committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    7e3952a View commit details
    Browse the repository at this point in the history